Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] lsp4e-cpp gerrit checking

Thanks, Doug, I'll look into that. What is the repo build?

Thanks,
Nate
________________________________________
From: cdt-dev-bounces@xxxxxxxxxxx <cdt-dev-bounces@xxxxxxxxxxx> on behalf of Doug Schaefer <dschaefer@xxxxxxxxxxxxxx>
Sent: June 1, 2018 2:15 AM
To: CDT General developers list.
Subject: Re: [cdt-dev] lsp4e-cpp gerrit checking

You just need set up the Maven pom files. The plug-ins only get included in the build if they're added to the repo build.

> -----Original Message-----
> From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On
> Behalf Of Nathan Ridge
> Sent: Thursday, May 31, 2018 6:38 PM
> To: CDT General developers list. <cdt-dev@xxxxxxxxxxx>
> Subject: Re: [cdt-dev] lsp4e-cpp gerrit checking
>
> Thanks Jonah!
>
> It would be nice to have a way of verifying that changes submitted to lsp4e-cpp
> are at least successfully compiling (and later, if we add test suites to the lsp4e-
> cpp plugin, that those tests are passing).
>
> Is there a way to do that without including lsp4e-cpp in what we ship yet?
>
> Thanks,
> Nate
>
> ________________________________________
> From: cdt-dev-bounces@xxxxxxxxxxx <cdt-dev-bounces@xxxxxxxxxxx> on behalf
> of Doug Schaefer <dschaefer@xxxxxxxxxxxxxx>
> Sent: May 31, 2018 2:53 PM
> To: CDT General developers list.
> Subject: Re: [cdt-dev] lsp4e-cpp gerrit checking
>
> Thanks Jonah, though we should get poms in place soon.
>
> The biggest problem is that the lsp editor overrides the current editor (or at least
> does when it starts up in a certain order). We'll need to figure that out before
> we go live with it.
>
> Doug.
>
> > -----Original Message-----
> > From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx]
> > On Behalf Of Jonah Graham
> > Sent: Thursday, May 31, 2018 6:35 AM
> > To: CDT General developers list. <cdt-dev@xxxxxxxxxxx>
> > Subject: [cdt-dev] lsp4e-cpp gerrit checking
> >
> > Hi folks,
> >
> > Its pretty exciting to see some lsp4e-cpp changes coming through!
> >
> > At the moment lsp4e-cpp is not part of the main build (i.e. it is
> > ignored if you do mvn ... in the cdt root). This means that the
> > cdt-verify-* jobs are rather pointless for changes containing lsp4e-cpp
> changes.
> > As a result I have disabled gerrit jobs running on changes to the
> > lsp4e-cpp directory.
> >
> > I have added a job that simply votes +1 for lsp4e-cpp changes. You can
> > see an example of that here: https://git.eclipse.org/r/#/c/123725/
> >
> > When the lsp4e-cpp is integrated into the maven configs I can add/edit
> > the Jenkins jobs.
> >
> > I hope that helps.
> > Jonah
> >
> >
> > ~~~
> > Jonah Graham
> > Kichwa Coders Ltd.
> > www.kichwacoders.com
> > _______________________________________________
> > cdt-dev mailing list
> > cdt-dev@xxxxxxxxxxx
> > To change your delivery options, retrieve your password, or
> > unsubscribe from this list, visit
> > https://dev.eclipse.org/mailman/listinfo/cdt-dev
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit https://dev.eclipse.org/mailman/listinfo/cdt-dev
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit https://dev.eclipse.org/mailman/listinfo/cdt-dev
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev


Back to the top