[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [cdt-dev] (Pre)Publishing my work on Refactorings
|
Hi,
that worked fine. The changes can now be found in gerrit and I'm happy
for every comment.
If I want to append further work I simply need to supply the same change
id as within the commit I just made, right?
Regards,
Simon
On 18.02.2014 18:30, Sergey Prigogin wrote:
You can create a separate branch that contains your work and on that
branch do a soft reset and then create a single commit that you can then
push to Gerrit.
-sergey
On Tue, Feb 18, 2014 at 9:18 AM, Simon Taddiken
<simon.taddiken@xxxxxxxxxxxxxx <mailto:simon.taddiken@xxxxxxxxxxxxxx>>
wrote:
Hi,
this sounds easy as I already committed a bugfix to gerrit. My
question here is: how do I create different patches for my
refactorings? I currently have one local branch (with about 200
commits) on which I did the implementation of all 3 refactorings. In
fact the pull up and push down refactoring are highly coupled as
they share a lot of mechanics.
How do I create pushable commits for gerrit now (the single commits
are not signed off but do have a change-id)?
Regards,
Simon
On 18.02.2014 16:20, Marc-André Laperle wrote:
Hi Simon,
You could push your changes to Gerrit. I suggest you push one
patch for
each refactoring. You could add a prefix like [WIP] (work in
progress)
in the commit title to make it clear that it's not ready for final
review. Here are a few links yo help you in the process:
https://wiki.eclipse.org/CDT/__contributing
<https://wiki.eclipse.org/CDT/contributing>
https://wiki.eclipse.org/CDT/__git#Using_Gerrit_for_CDT
<https://wiki.eclipse.org/CDT/git#Using_Gerrit_for_CDT>
I'm always interested in improvements in refactorings so I'll
definitely
give them a try!
Regards,
Marc-André
On 14-02-18 08:20 AM, Simon Taddiken wrote:
Hi Guys,
I would like to contribute my work on refactorings to the
CDT. The
implementation is still work in progress but most features
are already
working. Its mostly testcases that are missing. Also as I'm
new to
Eclipse (and CDT) development so my implementation might not be
flawless regarding all the CDT guidelines.
As this work is part of my bachelor thesis which is due in
about 8
weeks, it would be awesome if some experienced developers
and CDT
users could have a look on my work.
The refactorings I implemented are:
* Inline Temp
(http://refactoring.com/__catalog/inlineTemp.html
<http://refactoring.com/catalog/inlineTemp.html>)
* Push Down Field/Method
(http://refactoring.com/__catalog/pushDownMethod.html
<http://refactoring.com/catalog/pushDownMethod.html>)
* Pull Up Field/Method
(http://refactoring.com/__catalog/pullUpMethod.html
<http://refactoring.com/catalog/pullUpMethod.html>)
My question is whether there is a way to publish my work to
all who
are interested to have a look at it.
_________________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx <mailto:cdt-dev@xxxxxxxxxxx>
https://dev.eclipse.org/__mailman/listinfo/cdt-dev
<https://dev.eclipse.org/mailman/listinfo/cdt-dev>
_________________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx <mailto:cdt-dev@xxxxxxxxxxx>
https://dev.eclipse.org/__mailman/listinfo/cdt-dev
<https://dev.eclipse.org/mailman/listinfo/cdt-dev>
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev