Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] Proper handling of IP

> -----Original Message-----
> From: cdt-dev-bounces@xxxxxxxxxxx 
> [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Jeffrey Overbey
> Sent: Thursday, February 16, 2012 11:30 AM
> To: CDT General developers list.
> Subject: Re: [cdt-dev] Proper handling of IP
> > The patch is now more than 250 lines (445) but the CQ deadline
> > ...
> > Since the patch addresses multiple fixes, would it be ok to
> > split the solution into multiple bugs and multiple smaller patches?
> Doug can say for sure (or could check with the IP team), but you might
> be able to commit the patch as-is.  The point of the CQ process is to
> mitigate risk; "250 lines" was chosen somewhat arbitrarily as the
> definition of a "small" contribution which has very little risk.  This
> patch isn't THAT much over the limit, and many of his 445 lines are
> comments or import statements anyway, so it would probably get triaged
> if you filed a CQ.  Splitting it into multiple patches would waste
> time and wouldn't mitigate any additional risk... and it's definitely
> a "small" contribution with virtually no IP risk anyway (right?).

Absolutely.  The patch is safe in terms of IP.
I'm not worried about putting something in that I shouldn't.
I am worried about being a bad citizen and not following due process.
I don't want to cause CDT or myself any headaches with the foundation
(who is just protecting itself).

If I'm allowed to make a judgement call in this case, I feel it
is totally OK to commit the patch.


Back to the top