| RE: [cdt-dev] Target milestone 3.1.1 for bug #156187 - PathEntryf ramework should handle cygwin style paths on Windows |
|
I have no problem with that. I was
confused by the title I guess. You aren’t changing the framework, but the
toolchain definitions that plug into the framework, which I would think is the
right way to go. Another option would be to do something with
EFS to implement a cygwin file system that could do the translation at the
IResource level. But I need to learn more about EFS and how we could do that. From:
cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Ploett, Norbert Hi
Doug (and Mikhail), from
my perspective this is, first of all, a toolchain phenomenon: Include paths
(and lib, for that matter) have a representation which cannot be understood by
the PathEntry framework without translation. This toolchain speciality should
not be reflected in the PathEntry framework, rather the MBS should serve the
PathEntry framework with a standard representation of paths - i.e. one which is
understood by the eclipse platform. The
"Standard Make with Cygwin" case must of course also be handled.
Would be great if this goes sort of like automatically as Mikhail is
suggesting, alos I am not sure how this would go ... But then I am no expert in
this area. So
using path formats which are incompatible with the platform is a toolchain property.
For the MBS, where the toolchain is explicitly represented, the fix is best
done in the toochain specific part of the code. If
you still have thoughts about my approach then can you point me more
specifically to the region in the code where an alternative fix could be done? What
do you think? Norbert Von:
cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] Im Auftrag von Sennikovsky, Mikhail Hi Doug, I guess with the New Project Model enhancements in 4.0 when we have
the notion of the tool/tool-chain in the Standard Make as well, the enhancement
would get applied to the Standard Make projects as well. Mikhail From:
cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Doug Schaefer Looking
at the patch, I don’t see any changes to the core PathEntry framework,
which is shared with all builders. The changes appear to be managed build only.
Is that correct? Thansk, From:
cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Ploett, Norbert Hi folks, I have now supplied a fully
functional bugfix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=156187,
a few things remain TBD (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=156187#c6)
I'll strive to supply everything and I am confident that it can be done by
Thursday next week. I'd love to see this in 3.1.1 but I
don't intend to blast the timeline so if there is a serious technical argument
against this and the schedule is threatened I'll also retract this. But otherwise I want it in :-) This is just to draw attention so
everybody gets a chance to look at my solution. Thanks, Norbert |