Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [4diac-dev] CSinglyLinkedList improvements

Hi Davor,

thanks for looking on our code and trying to improve it. We have this single list implementation because when we started 4diac FORTE we had platforms that had
no STL available. Now this is obsolete and my personal goal is to get rid of it step by step. 

Therefore my suggestion is no new code should use CSinglyLinkedList anymore. Better use std:vector.

Therefore I'm also not sure if it makes sense to spend time on improving it. What are you or others thinking.


On Thu, 2022-04-28 at 21:30 +0200, Davor Cihlar wrote:
> Hi again!
> Since Forte moved to c++11 I'm using the new features in my PostgreSQL implementation. To be able to use std::move properly I've upgraded CSinglyLinkedList.
> I would like to contribute those changes, but first I think it would make sense to know nobody else is working on this?
> While I was at it, I also noticed some irregularities in the implementation. In a few places const is not used properly. I.e. CSinglyLinkedList::begin()const
> is returning a const Iterator - an Iterator that can only stay in one place! Instead of returning a non-const Iterator that handles const data. At some point
> I actually had a problem with that.
> It appears that this doesn't matter for the whole Forte code, but it still should probably be fixed. On the other hand this may be a bit more work.
> Now, before making any contributions, I also need to figure out first how unit testing is set up on this project.
> _______________________________________________
> 4diac-dev mailing list
> 4diac-dev@xxxxxxxxxxx
> To unsubscribe from this list, visit

Back to the top