Re: [orbit-dev] org.apache.httpcomponents.httpclient OSGi bundle and com

[Václav Haisman <vhaisman@xxxxxxxxx>]

čt 16. 6. 2022 v 14:33 odesílatel Jonah Graham <jonah@xxxxxxxxxxxxxxxx> napsal:

Hi Václav, 

Can you please be explicit about which bundles you are referring to? AFAICT this request has already been done (in 2020): https://git.eclipse.org/r/c/orbit/orbit-recipes/+/168441 - if you are seeing something different then perhaps I haven't mapped your question to the specific bundles, or perhaps you are pointing at an older recommended build. See https://www.eclipse.org/lists/orbit-dev/msg05562.html for the announcement on the latest recommended one.

I am afraid the commit message says something else than the change actually does. To achieve what the commit message suggests it is necessary to patch the current master branch like this (also attached):

diff --git a/apache/httpcomponents/org.apache.httpcomponents.httpclient_4.5.13/osgi.bnd b/apache/httpcomponents/org.apache.httpcomponents.httpclient_4.5.13/osgi.bnd
index 4c0b973..897af9c 100644
--- a/apache/httpcomponents/org.apache.httpcomponents.httpclient_4.5.13/osgi.bnd
+++ b/apache/httpcomponents/org.apache.httpcomponents.httpclient_4.5.13/osgi.bnd
@@ -7,7 +7,7 @@ memcached-version=${version;==;2.12.3}
 
 httpcore-version-range=${range;[===,=+);${httpcore-version}}
 commons-logging-version-range=${range;[===,=+);${commons-logging-version}}
-commons-codec-version-range=${range;[===,=+);${commons-codec-version}}
+commons-codec-version-range=${range;[===,+);${commons-codec-version}}
 ehcache-version-range=${range;[==,+);${ehcache-version}}
 memcached-version-range=${range;[==,+);${memcached-version}}

 

The Orbit bundles are maintained by the Eclipse projects* that consume the bundles, so whichever Eclipse project needs such a change is more than welcome to test and provide the update. As you can see from the above quoted gerrit, the actual change itself is easy enough. 

*Said in another way, there is no one on the "Orbit team". I release what is in Orbit and will help projects contribute new bundles, but I don't have the resources to actually build and test bundles or their modifications.

I see

 

--

VH

From 397a365839539d13f6d3a57c49f4e54093d0dd11 Mon Sep 17 00:00:00 2001
From: Vaclav Haisman <vaclav.haisman@xxxxxxxxxxxx>
Date: Thu, 16 Jun 2022 15:07:49 +0200
Subject: [PATCH] org.apache.httpcomponents.httpclient:
 commons-codec-version-range=${range;[===,+);${commons-codec-version}}

---
 .../org.apache.httpcomponents.httpclient_4.5.13/osgi.bnd      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/apache/httpcomponents/org.apache.httpcomponents.httpclient_4.5.13/osgi.bnd b/apache/httpcomponents/org.apache.httpcomponents.httpclient_4.5.13/osgi.bnd
index 4c0b973..897af9c 100644
--- a/apache/httpcomponents/org.apache.httpcomponents.httpclient_4.5.13/osgi.bnd
+++ b/apache/httpcomponents/org.apache.httpcomponents.httpclient_4.5.13/osgi.bnd
@@ -7,7 +7,7 @@ memcached-version=${version;==;2.12.3}
 
 httpcore-version-range=${range;[===,=+);${httpcore-version}}
 commons-logging-version-range=${range;[===,=+);${commons-logging-version}}
-commons-codec-version-range=${range;[===,=+);${commons-codec-version}}
+commons-codec-version-range=${range;[===,+);${commons-codec-version}}
 ehcache-version-range=${range;[==,+);${ehcache-version}}
 memcached-version-range=${range;[==,+);${memcached-version}}
 
-- 
2.36.1.windows.1