[xtext-dev] Approval of changes by peer reviewer

[Karsten Thoms <karsten.thoms@xxxxxxxxx>]

Dear team members,

I would like to remind you that any non-trivial change requires peer review before merging, see #8 in QUALITY_GUIDELINES [1]. This does mean that merging changes must not happen until some other committer has reviewed and approved the change. The guideline does not mention that the reviewer has to perform the „Review changes“ with the „Approve“ option finally. This has just been common sense ever since. If this is not clear enough then we should update the documentation.

Kind regards,

~Karsten

[1] https://github.com/eclipse/xtext/blob/master/QUALITY_GUIDELINES.md