Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [wtp-dev] Request PMC approval for 139863 for 1.0.3


If there is a situation where the VM version cannot be detected, IMHO the best solution would be to allow the user to specfiy the VM Version. If the user actually only has a 1.4 level VM installed and you decide to treat it as a 1.5 level VM other sorts of problems could show up. Maybe the wizard could have an "Advanced" section where the user could choose from "Autodected VM" or override the detected VM to one they specify. If this clutters up the wizard, it could be put into the preferences dialog.

Just my 2 cents.


Thanks,

Mindaugas Idzelis
IBM Rational Middleware




"Konstantin Komissarchik" <kosta@xxxxxxx>
Sent by: wtp-dev-bounces@xxxxxxxxxxx

05/04/2006 09:23 AM

Please respond to
"General discussion of project-wide or architectural issues." <wtp-dev@xxxxxxxxxxx>

To
"General discussion of project-wide or architectural issues." <wtp-dev@xxxxxxxxxxx>
cc
Subject
RE: [wtp-dev] Request PMC approval for 139863 for 1.0.3





Thanks, Sachin. It's good to know that at least starting with 1.5 the
MacOS user WTP experience will be improved. If we put the fix that I am
proposing into 1.0.3, the MacOS users will not have to wait until 1.5 to
get this working better.

Regarding the JRockit VM, the problem is a bit more complicated. There
is no custom IVMInstall implementation. The standard implementation just
works in some cases and not others (same vm version). We are not sure
yet whether this is intermittent or environment sensitive.

The MacOS example illustrates well the problem facing us. The JDT
interfaces we use make no guarantee that they will be able to get the
version number. We need to put in place a better workaround so that we
don't strand the users with not being able to use 5.0 features of their
VM.

- Konstantin



-----Original Message-----
From: wtp-dev-bounces@xxxxxxxxxxx [mailto:wtp-dev-bounces@xxxxxxxxxxx]
On Behalf Of Sachin Patel
Sent: Thursday, May 04, 2006 4:51 AM
To: General discussion of project-wide or architectural issues.
Subject: Re: [wtp-dev] Request PMC approval for 139863 for 1.0.3

Hi Konstantin, the version cannot be detected on MacOS because the of  
the implementation of MacOSXVMInstall does not override the null  
returning abstract impl of getJavaVersion().  This is fixed in 3.2.  
As far as JRockit, it could be that you need to provide a custom VM  
Type and implementation of IVMInstall.

- sachin



On May 3, 2006, at 11:59 PM, Konstantin Komissarchik wrote:

> A bit more background on this issue...
>
>
>
> We rely on being able to accurately determine the version of the  
> java vm of the server runtime in order to control which versions of  
> the java facet the user should be able to select. For instance if  
> the VM version is 1.4, the user can select java facet version 1.3  
> and 1.4. Unfortunately, there are cases (as of yet not understood)  
> where JDT fails to determine the VM version. This behavior has been  
> seen on Mac OS (not sure which VM) and it has recently started  
> showing up sporadically with BEA's JRockit VM. The current code  
> arbitrarily assigns version 1.4 to the VM when the version cannot  
> be determined. The problem with that is that if the actual version  
> happens to be 5.0 the user cannot pick version 5.0 of java facet  
> (and hence the corresponding java compiler level). There is no  
> workaround. It is going to take some time to understand exactly why  
> version detection fails and to forward that information to the JDT  
> team. In the meantime we can make this problem less severe by using  
> the highest known VM version (5.0 in the case of 1.0.x) instead of  
> 1.4. This approach places the least restriction on the user. With  
> this approach, the user will always be able to compensate for the  
> VM version detection problem by picking the correct version of the  
> java facet on the facets selection screen. While not perfect, it's  
> much better than what we currently have and I highly recommend that  
> we make this fix for 1.0.3.
>
>
>
> Does anyone have any comments on this?
>
>
>
> - Konstantin
>
>
>
>
>
> From: wtp-dev-bounces@xxxxxxxxxxx [mailto:wtp-dev-
> bounces@xxxxxxxxxxx] On Behalf Of Konstantin Komissarchik
> Sent: Tuesday, May 02, 2006 3:34 PM
> To: General discussion of project-wide or architectural issues.
> Subject: [wtp-dev] Request PMC approval for 139863 for 1.0.3
>
>
>
> See https://bugs.eclipse.org/bugs/show_bug.cgi?id=139863 for details.
>
>
>
> This bug covers improving our workaround for the case where java vm  
> cannot be detected. The current behavior is rather bad for people  
> who hit it and the fix is pretty safe.
>
>
>
> - Konstantin
>
> ______________________________________________________________________

> _ Notice: This email message, together with any attachments, may  
> contain information of BEA Systems, Inc., its subsidiaries and  
> affiliated entities, that may be confidential, proprietary,  
> copyrighted and/or legally privileged, and is intended solely for  
> the use of the individual or entity named in this message. If you  
> are not the intended recipient, and have received this message in  
> error, please immediately return this by email and then delete it.  
> ______________________________________________________________________

> _ Notice: This email message, together with any attachments, may  
> contain information of BEA Systems, Inc., its subsidiaries and  
> affiliated entities, that may be confidential, proprietary,  
> copyrighted and/or legally privileged, and is intended solely for  
> the use of the individual or entity named in this message. If you  
> are not the intended recipient, and have received this message in  
> error, please immediately return this by email and then delete it.  
> ______________________________________________________________________

> _ Notice: This email message, together with any attachments, may  
> contain information of BEA Systems, Inc., its subsidiaries and  
> affiliated entities, that may be confidential, proprietary,  
> copyrighted and/or legally privileged, and is intended solely for  
> the use of the individual or entity named in this message. If you  
> are not the intended recipient, and have received this message in  
> error, please immediately return this by email and then delete it.
> _______________________________________________
> wtp-dev mailing list
> wtp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/wtp-dev

_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-dev
_______________________________________________________________________
Notice:  This email message, together with any attachments, may contain
information  of  BEA Systems,  Inc.,  its subsidiaries  and  affiliated
entities,  that may be confidential,  proprietary,  copyrighted  and/or
legally privileged, and is intended solely for the use of the individual
or entity named in this message. If you are not the intended recipient,
and have received this message in error, please immediately return this
by email and then delete it.
_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-dev


Back to the top