| Re: [tycho-user] Error - 7 icon(s) not replaced in ... using ... |
|
i did play some more with it: it seems the maven-resources-plugin copies only the contents of the folder, not the folder itself. Also, i misread the link you gave Mort gave me (http://software.2206966.n2.nabble.com/How-to-apply-patch-no-launcher-icon-TYCHO-300-td6059641.html); the tycho-p2-publisher-plugin uses "${project.build.directory}/products/${product-id}" (and not "${project.build.directory}/products/${project.groupId}.${project.artifactId}" as i used in a previous mail). As an exercise i forked Jan Sievers tycho-demo project and adapted it: (It now uses the maven-resources-plugin instead of a tycho-specific path) From: davymeers@xxxxxxxxxxx To: tycho-user@xxxxxxxxxxx Date: Tue, 14 Jun 2011 19:09:40 +0200 Subject: Re: [tycho-user] Error - 7 icon(s) not replaced in ... using ... You are right: it seems tycho does perform another clean after the validate phase. The generate-resources phase happens after that clean. (This leaves me wondering how i managed to make it work with the validate phase) Greetings, Davy > Date: Tue, 14 Jun 2011 19:44:18 +0300 > From: mn@xxxxxxxxx > To: tycho-user@xxxxxxxxxxx > Subject: Re: [tycho-user] Error - 7 icon(s) not replaced in ... using ... > > On 06/14/2011 05:42 PM, motes motes wrote: > > > Thanks for the tip about using maven-resources-plugin instead, but I > > cannot make it work. I have the icons folder in the root of my folder: > > > > myproduct > > | --> icons > > | --> app.ico > > | -- > myproduct.product > > | -- > pom.xml > > > > In the pom I have: > > > > <plugin> > > <artifactId>maven-resources-plugin</artifactId> > > <executions> > > <execution> > > <id>copy-resources</id> > > <!-- here the phase you need --> > > <phase>validate</phase> > > It seems validate phase is too early, I would rather use > process-resources, generate-resources or even prepare-package phase. Try > to run 'mvn --debug' and check the log - it should contain a lot of details. > > > <goals> > > <goal>copy-resources</goal> > > </goals> > > [skip] > > > but the content (or the icons folder) never gets copied to the target > > path specified in the outputDirectory tag. I have read the > > documentation here: > > -- > Mykola > _______________________________________________ > tycho-user mailing list > tycho-user@xxxxxxxxxxx > https://dev.eclipse.org/mailman/listinfo/tycho-user _______________________________________________ tycho-user mailing list tycho-user@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/tycho-user |