[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
[tycho-dev] gerrit voter and ITs
|
Hi,
up to now our gerrit voter job
https://hudson.eclipse.org/tycho/job/tycho-gerrit/
verified that for each gerrit proposal, we have a successful build (including unit tests), but did not execute (long-running) ITs.
The problem here is we want both fast feedback (<5 min) whether the build succeeded and the added value of automatically verifying ITs are successful (ITs typically take 20-30 minutes to execute).
I changed the gerrit voter job now to
1. run the build
2. notify gerrit if build successful (this will trigger a mail like the one below)
3. run ITs
Only if ITs are successful, a +1 verdict is sent to gerrit.
(of course, a -1 verdict is also sent in case step 1 fails)
A test gerrit patchset is here
https://git.eclipse.org/r/#/c/20486/
If you think this is a good approach, I would try to do the same thing for tycho-extras.
Regards,
Jan
--- sample gerrit mail ---
Hudson CI has posted comments on this change.
Change subject: test
......................................................................
Patch Set 3:
Build SUCCESSFUL. Now starting integration tests...
--
To view, visit https://git.eclipse.org/r/20486
To unsubscribe, visit https://git.eclipse.org/r/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb6ed3536ef1118063ed0c16caa94afd438971be
Gerrit-PatchSet: 3
Gerrit-Project: tycho/org.eclipse.tycho
Gerrit-Branch: master
Gerrit-Owner: Jan Sievers <jan.sievers@xxxxxxx>
Gerrit-Reviewer: Hudson CI
Gerrit-Reviewer: Jan Sievers <jan.sievers@xxxxxxx>
Gerrit-HasComments: No