| Re: [tycho-dev] Resolving Surefire Eclipse Installation wrongly uses all environments |
I suppose that you want to contribute these changes, correct? This is great, but please follow the Tycho Contributor Guide
Regards
Tobias
From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of Tonny Madsen
Sent: Dienstag, 20. November 2012 09:30
To: Tycho Dev List
Subject: [tycho-dev] Resolving Surefire Eclipse Installation wrongly uses all environments
Hi all,
Another pull request, I hope you can take a look at: https://github.com/eclipse/tycho/pull/4
I have a tycho-surefire test that fails because one of the dependencies it -org.eclipse.jdt.launching.macosx - has a platform filter - (osgi.os=macosx).
As far as I can see, the test fails as the Eclipse Installation used by tycho-surefire is resolved using all the defined environments in the target-platform-configuration.environments - just like the "normal" compile environment - and not just the environment of the running platform, which I would have expected. If I temporarily removes the defined environments from the target-platform-configuration, then everything works.
Looking at the sources, I can see TestMojo (indirectly) uses P2TargetPlatformResolver.doResolvePlatform which unconditionally sets the current environment as set in target-platform-configuration before resolving the project with P2Resolved.
This patch introduces an addition to DependencyResolverConfiguration: getEnvironments(). This method is then overriden in TestMojo to just return the current executing environment.
/Tonny
--
Tonny Madsen
My profiles:
_______________________________________________
tycho-dev mailing list
tycho-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tycho-dev
Tonny Madsen