Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-dev] Get contributions into 0.16

On 10/05/2012 02:20 PM, Mickael Istria wrote:
On 10/05/2012 01:24 PM, Igor Fedorenko wrote:
On 12-10-05 6:05 AM, Mickael Istria wrote:
Hi all,

I'm trying to find out the process to get committers attention on issues
that I think are good to go into 0.16. I tried to set Target Milestone
on bug, but it seems that it is not the appropriate way. For those
issues, I provided patches, that you just have to review, and merge in
case you like them So I send my (short) wish list here:
* https://git.eclipse.org/r/#/c/7636/
https://bugs.eclipse.org/bugs/show_bug.cgi?id=388084 Setting by default
-XstartOnFirstThread on Mac. That would save a lot of lines in pom.xml
that are necessary to workaround tycho-surefire-plugin to work on mac
when using UI.

This is on my to do list to review properly, but I did not have the time
yet and most likely won't be able to do in time for 0.16. I generally
try to avoid hardcoded magic strings, especially when there is no way to
disable them, but it may be okay in this particular case. I am not sure
if System.getProperty should be used there either.
Jan gave some interesting feedback on the bug. I'll take them into account and will produce a new patch. I marked current contribution as -1 for reasons given by Jan.

I just submitted a new patch. Let's continue discussion here: https://git.eclipse.org/r/#/c/7636/
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat
My blog - My Tweets

Back to the top