Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-dev] [tycho-user] <optionalDependencies> configuration parameter

Here is a draft of the new configuration format [1]. I plan to implement
this for 0.14, but still allow current format with a scary deprecation
warning.

Comments, suggestions?

[1] https://gist.github.com/1603222

--
Regards,
Igor

On 12-01-09 1:13 PM, Igor Fedorenko wrote:
<optionalDependencies> affects dependency resolution. compiler-plugin is
one consumer of resolved dependencies, but optionalDependencies should
affect all consumers of resolved project dependnecies, so having
optionalDependencies under compiler configuration is misleading.

<executionEnvironment> affects target platform collection, dependency
resolution, compilation, tests and other cases I don't currently see, so
having executionEnvironment under target platform configuration is
misleading.

<extraRequirements> affect dependency resolution and test runtime, so
having it configured under compiler configuration is misleading.

Originally, Tycho only needed to configure target platform calculation
logic, but this is clearly not the case any more. So why look for
"mostly" appropriate places for new configuration parameters, when
proper solution is possible?

--
Regards,
Igor

On 12-01-09 12:43 PM, Oberlies, Tobias wrote:
Do you still think that optionalDependencies should both affect the
compiler and test runtime? If not, what is wrong with specifying
parameters that (mostly) affect only the compiler in the
tycho-compiler-plugin configuration section?

Bug 367701 is independent on how (syntactically) the optional
dependencies resolution behaviour is specified. The root cause is
that there is a intra-reactor side-effect of configuration in one
module on another module. This would be no different with a different
configuration location.

Regards Tobias >
Igor Fedorenko wrote:
Yes, there is a pressing need for consistent long-term approach to
capture Tycho configuration in pom.xml file, and bug 367701 just proves
this need.

Although backwards compatibility is certainly is a concern, I want to
decide on ideal configuration format first, before looking at
compatibility issues.

--
Regards,
Igor

On 12-01-09 8:36 AM, Oberlies, Tobias wrote:
This seems like a proposal for an incompatible change. I don't really
see a pressing need for this. Did we not figure out, that the effect
of the optionalDependencies compiler-plugin parameter on the test
runtime is rather is buggy [1] and needs to be revised anyway?>
Regards
Tobias

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=367701


-----Original Message-----
From: tycho-user-bounces@xxxxxxxxxxx [mailto:tycho-user-
bounces@xxxxxxxxxxx] On Behalf Of Igor Fedorenko
Sent: Montag, 9. Januar 2012 13:30
To: tycho-user@xxxxxxxxxxx
Subject: Re: [tycho-user]<optionalDependencies> configuration
parameter


On 12-01-03 4:34 AM, Mickael Istria wrote:
On 30/12/2011 16:23, Igor Fedorenko wrote:
1. tycho-compiler-plugin<configuation> block
-1.
IMHO tycho-compiler-plugin is the place where to deal with compiling
options, such as flags to enable line numbers in compiled code. This
is
not the place where I'd look for resolution of
dependencies/classpath.

2. new target-dependency-configuration<configuration> block,
separate
from target-platform-configuration
3. new target-resolver-configuration<configuration> block, that
supersedes target-platform-configuration and allows configuration of
all
aspects of Tycho dependency resolution
IMHO, both would be fine. Of both, I tend to prefer target-resolver
because the word "resolution" is very clear and most stuff I red
about
the optionalDependency issue do mention the word "resolve".


How about generic tycho-configuration<configuration> block, which will
allow either subsection or use feature:parameter naming convention to
separate configuration parameters the control different parts of Tycho
behaviour, i.e. target platform, dependency resolution, p2 parameters
and so on?

Some configuration parameters, like<executionEnvironment>,
that should apply to pretty much everything Tycho does -- target
platform collection, dependency resolution, compilation, and running
the
test. Today we configure such parameters under
target-platform-configuration<configuration> block, and I think this
is
rather confusing.

--
Regards,
Igor
_______________________________________________
tycho-user mailing list
tycho-user@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tycho-user


Back to the top