| Re: [tracecompass-dev] Deprecating TimeGraphCombo |
Hi Jonathan,All uses of the deprecated class have been replaced in the Trace Compass plug-ins and the change is mostly functionally compatible.This means there is nothing more to do in Trace Compass. Everything that needs to be updated has already been taken care of in the patch. The 'mostly' in 'mostly functionally compatible' only potentially affects external projects that provide their own implementation of AbstractTimeGraphView.Any subclass of this view (in plug-in extensions outside of Trace Compass) that explicitly accesses the time graph combo will need to be updatedThis means that only code that is outside of Trace Compass might possibly break. But it will only break if it uses a reference to the time graph combo, which is not required to do if a subclass of AbstractTimeGraphView only implements the required API to provide a time graph model, without adding any specific functionality that requires access to the combo.Best regards,Patrick
On Fri, Dec 16, 2016 at 10:06 AM, Jonathan Rajotte Julien <Jonathan.rajotte-julien@xxxxxxxxxxxx> wrote:Hi,
On 2016-12-15 06:27 PM, Patrick Tasse wrote:
On Thu, Dec 15, 2016 at 5:49 PM, Jonathan Rajotte Julien <Jonathan.rajotte-julien@efficios.com <mailto:Jonathan.rajotte-julien@xxxxxxxxxxxx >> wrote:
Could you provide a list of code needing that update? This would
allow a faster and more complete change.
A subclass of AbstractTimeGraphView that doesn't use getTimeGraphCombo() should work out of the box, whether it uses columns or not.
In most cases calls to getTimeGraphCombo() can get replaced with getTimeGraphViewer().
Calls to setSelection(entry) on the combo should be replaced with setSelection(entry, true) on the time graph viewer.
If the user called getTree() on the combo, the tree returned by the time graph viewer only has column headers and no tree items. For example CallStackView was adding an IDoubleClickListener on the tree. This had to be replaced by a mouseDoubleClick() MouseListener on the time graph control, with the selection fetched from the viewer instead of from the DoubleClickEvent. That was the hardest update required in Trace Compass.
Thanks for the thorough "how to" but you are not answering the question.
You seem to imply that some code might need changes to prevent breaking.
"I can help anyone that needs advice for updating their code to use a time graph viewer instead of a time graph combo."
Thus the question "Could you provide a list of code needing that update?" regarding TC code base.
Let me rephrase: Does merging the proposed changes "as is" break stuff currently present in Trace Compass (also known as "regression")?
If so, since you are proposing the change and that you are a part of the maintaining team, I would expect that you provide a detailed list of what need to be done and by who (maintainers or specific contributors) to ensure that weird stuff do not happen and nothing break.
This would allow people like me, who would like this merged asap, to help.
You are the one currently playing in this part and have probably much more insight regarding what will break (you did not provide all of this information) and how it will break (you provided this information).
Otherwise, discard the previous paragraph (well you can still read it to make sure I do not say anything stupid).
Cheers
Patrick
_______________________________________________
tracecompass-dev mailing list
tracecompass-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/tracecompass-dev
--
Jonathan R. Julien
Efficios
_______________________________________________
tracecompass-dev mailing list
tracecompass-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/tracecompass-dev