Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tracecompass-dev] StringStateValue - limit on string size with FULL history?

Patch https://git.eclipse.org/r/#/c/77783/ should be part of it too.


Bernd


On 07/29/2016 06:23 PM, Marc-André Laperle wrote:
I think we could consider making a 2.0.1 release soon with bug fixes. Are there any other important bug fixes that could go in?
Opinions?

Marc-Andre


From: tracecompass-dev-bounces@xxxxxxxxxxx [tracecompass-dev-bounces@xxxxxxxxxxx] on behalf of Rocky Dunlap - NOAA Affiliate [rocky.dunlap@xxxxxxxx]
Sent: Friday, 29 July 2016 6:15 PM
To: tracecompass developer discussions
Subject: Re: [tracecompass-dev] StringStateValue - limit on string size with FULL history?

Since this is an important bug fix, would it be possible to cherry pick and push it to the P2 repo as a 2.0 patch release so that clients would get the update before September?  

Rocky

On Fri, Jul 29, 2016 at 4:10 PM, Alexandre Montplaisir <alexmonthy@xxxxxxxxxxxx> wrote:
Hi Rocky,

You can use the nightly builds, which are built every day from the master branch, and which include that particular commit:
http://download.eclipse.org/tracecompass/master/rcp/

We could also cherry-pick that commit to the stable-2.0 branch, it is not too intrusive but is quite an important bug fix. With that you could update a 2.0 RCP to receive that change.

Cheers,
Alexandre



On 2016-07-29 05:33 PM, Rocky Dunlap - NOAA Affiliate wrote:
Geneviève,

That's good news.

When will the new commit be released?  Until then I will work around with
127 char limit.

Thanks,
Rocky

On Fri, Jul 29, 2016 at 3:28 PM, Geneviève Bastien <
gbastien+lttng@xxxxxxxxxxxx> wrote:

Hi Rocky,

The history tree used to limit the size of Strings to 127 bytes, but it
wasn't checked, it was hoping that the caller would not add larger strings.
This was fixed in commit [1] The strings now have a maximum of 32767 bytes.
But from the date, it is not part of TraceCompass 2.0. If you get a
development snapshot though you'll be able to put larger strings in the
history tree.

[1]
http://git.eclipse.org/c/tracecompass/org.eclipse.tracecompass.git/commit/?id=8182f36f96bbe3f33cc4c4838853239d2efe315a

Best regards,
Geneviève





On 07/29/2016 05:01 PM, Rocky Dunlap - NOAA Affiliate wrote:

I have a state system set up using the FULL history backend.  I noticed
that I was receiving the stack trace below when the history is read back in
from file.  The issue goes away when I limit the size of strings in
StringStateValue to less than 100 bytes.

I tried to up the blocksize from 64*1024 to some very large value, but
that did not seem to do the trick.  I did not study it exhaustively, but I
did not see any checking in the HTNode write code to prevent buffer
overruns.  Maybe that is the issue?

Basically, I'd like to know how I can store longer strings using the FULL
history option.  It works fine when using the INMEM option, but I'll need
the disk option for larger traces.


java.lang.NegativeArraySizeException
at
org.eclipse.tracecompass.internal.statesystem.core.backend.historytree.HTInterval.readFrom(HTInterval.java:187)
at
org.eclipse.tracecompass.internal.statesystem.core.backend.historytree.HTNode.readNode(HTNode.java:218)
at
org.eclipse.tracecompass.internal.statesystem.core.backend.historytree.HT_IO.readNode(HT_IO.java:140)
at
org.eclipse.tracecompass.internal.statesystem.core.backend.historytree.HistoryTree.buildLatestBranch(HistoryTree.java:223)
at
org.eclipse.tracecompass.internal.statesystem.core.backend.historytree.HistoryTree.<init>(HistoryTree.java:197)
at
org.eclipse.tracecompass.internal.statesystem.core.backend.historytree.HistoryTreeBackend.<init>(HistoryTreeBackend.java:148)
at
org.eclipse.tracecompass.statesystem.core.backend.StateHistoryBackendFactory.createHistoryTreeBackendExistingFile(StateHistoryBackendFactory.java:116)
at
org.eclipse.tracecompass.tmf.core.statesystem.TmfStateSystemAnalysisModule.createFullHistory(TmfStateSystemAnalysisModule.java:302)
at
org.eclipse.tracecompass.tmf.core.statesystem.TmfStateSystemAnalysisModule.executeAnalysis(TmfStateSystemAnalysisModule.java:227)
at
org.eclipse.tracecompass.tmf.core.analysis.TmfAbstractAnalysisModule$1.run(TmfAbstractAnalysisModule.java:351)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)


Thanks!
Rocky


_______________________________________________
tracecompass-dev mailing listtracecompass-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visithttps://dev.eclipse.org/mailman/listinfo/tracecompass-dev



_______________________________________________
tracecompass-dev mailing list
tracecompass-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/tracecompass-dev




_______________________________________________
tracecompass-dev mailing list
tracecompass-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/tracecompass-dev

_______________________________________________
tracecompass-dev mailing list
tracecompass-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/tracecompass-dev



_______________________________________________
tracecompass-dev mailing list
tracecompass-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/tracecompass-dev


Back to the top