| Re: [tracecompass-dev] TotalADS: Total Anomaly Detection System |
|
Hi Shariyar,
Excellent news that your plugin is ready to be pushed. We'll gladly review it. Introducing your functionnality is a good first step to committing! You should also read the contributor's guidelines for Trace Compass here https://wiki.eclipse.org/Trace_Compass/Contributor_Guidelines. Since you are not a committer on the project and there are no committer at Concordia, your whole contribution will probably have to go through a CQ (Contribution Questionnaire) before being integrated. Here are some pointers for big functionnalities like this: - You say you didn't need to modify anything at all in the other plugins, but if you did (even a one-liner somewhere), push those separately and first. - Split the functionnality: A huge patch will wait on gerrit. It's hard to get into someone else's code and understand what it does, so small patches are easier to get into, especially if they provide one single feature that can be tested individually (even if it is only a partial feature, with lots more to come). - If you can, don't push all patches at once, but start with a few small standalone ones that we can test separately. A contributor's first patches usually receive a lot of comments on code style and advices, so be ready for a few back and forth reviews at the beginning, then you get experienced and it somehow gets easier ;-) - Provide some documentation on each patch, provide test traces, so it's easy to test. You can do that in the comments on gerrit. - Your functionnality is in its own plugin, already separated in core and UI, with unit tests, so it shouldn't be too bad to get it in. Happy contributing! :) Cheers, Geneviève On 11/25/2014 11:31 AM, Shariyar wrote:
|