Re: [theia-dev] Failing license checks on PR's

[Thomas Mäder <t.s.maeder@xxxxxxxxx>]

Hi Marc,

------ Original Message ------

From "Marc Dumais" <marc.dumais@xxxxxxxxxxxx>

To "theia developer discussions" <theia-dev@xxxxxxxxxxx>; "Thomas Mäder" <t.s.maeder@xxxxxxxxx>

Cc "Wayne Beaton" <wayne.beaton@xxxxxxxxxxxxxxxxxxxxxx>

Date 29/03/2023 17:32:01

Subject Re: [theia-dev] Failing license checks on PR's

In such a case, what we have done in the past is to add the dependency in question as an entry into our repo's "ignore list" file, "dependency-check-baseline.json", that lives in the repo root.  The entry should mention that this dependency is still under review. This shows that we included it on purpose, and also this will make the license check pass. I suggest that we do that just before the release tomorrow, if the dependency has not yet been approved.

Sounds like a plan?

Yup.

/Thomas