Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [theia-dev] New feature enabled for CI: Require branches to be up to date before merging
  • From: Marc Dumais <marc.dumais@xxxxxxxxxxxx>
  • Date: Thu, 23 Mar 2023 15:00:20 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jbEnhtV4u8MGtGnJ5o9Gs2wm/M43Wji/uuGfNZml/zU=; b=LBWdXujzVcFXKyYU0/FvWQ/QLjdDQvX4S+260DD1K8upu3xHzP50i6mURrCA7tsQjDPWxjiQ/ba5ANjTKHYfLDrTCaT3FhdAfGHhVkhWIeYM9k5Psuy//0F77iRvaUMVJGrh657X6S4Np2qrslGDJs6Vo8vpHalQ7oQqvFaVSmERW3Bv8osyGk77c1ZLU8EiC1clkOgRHUt1VQ1IMR4sSd4rGlJfpIBHN5p2pdS7MIO/Rv/0T5+bvTLnRSwCEH5RpzGqUjdq330mN7nJfc4KNTZ8psyMu7piDVDZzTry4PIcWGiUVDj5j+0rm/9TgQS9xbFMIz1ZvJuUl0w+2USM8A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mWRyBDxYaJ4W1Md+e2+lKLzXO39kVvSh3VfVloLcve42h0rGEcVjqCd0W2Eh6+8in6MUqMxmF9rIYk5VjyZvkGWaBj2HdRbZGqS+UBPslcAp6Cz+8IhwX2v/hxvIcZ/D91IKLTFgrWmOOGQiaxqfyoegVi5r9qhZNq+zw18S1M6AcXHs2rRbrkOdwn7TvizDRXBeGxn/62rEhrEiOjdX4viktet0c9JbBymFAM9u08+HTWILVa4UkCyETt8fjX/UgBEMOo/wNjVpfnTjy9PutrYuetehxWfgvHe1Z/1mw4AxZNk6Fgr+MPmtHXG2+/gdB+mPv9DDe9X+x9fUSuCErg==
  • Delivered-to: theia-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/theia-dev/>
  • List-help: <mailto:theia-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/theia-dev>, <mailto:theia-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/theia-dev>, <mailto:theia-dev-request@eclipse.org?subject=unsubscribe>
  • Msip_labels:
  • Thread-index: AQHZXY7F2oE1JyYYQ0GvJQ3HifOszq8IbqqAgAABt+s=
  • Thread-topic: [theia-dev] New feature enabled for CI: Require branches to be up to date before merging
Hi Thomas,

I had not thought about that, but it does make sense. In fact, I do see it happening on your PR about enabling context isolation, that originates from your fork, where presumably you have not granted permission for maintainers to edit. 

That, coupled with the need for one of our project committers (user with write access to our repo) to push the "Approve and run" CI button, post-branch-update, might make for a bit of back-and-forth between us and external (non-committer) contributors. 

One thing we could do to mitigate this is to update our PR template to encourage external contributors to grant us "allow edits from maintainers" on their PR? Maybe we can do this after the trial period of one month is over?

Regards,
Marc
From: theia-dev <theia-dev-bounces@xxxxxxxxxxx> on behalf of Thomas Mäder <t.s.maeder@xxxxxxxxx>
Sent: Thursday, March 23, 2023 10:36 AM
To: theia developer discussions <theia-dev@xxxxxxxxxxx>
Subject: Re: [theia-dev] New feature enabled for CI: Require branches to be up to date before merging
 
Very cool, thank you. 
I guess you need write access to the branch to be merged in order to see the "Update branch" button, right? Because it's your own branch or the contributor checked "allow edits from maintainers"?

/Thomas


Back to the top