Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [theia-dev] Master breakage
  • From: Marc Dumais <marc.dumais@xxxxxxxxxxxx>
  • Date: Thu, 16 Mar 2023 14:15:57 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Rw9koaKgvnax1ptyykkCkRJL1Kr5xgGVRE2IgyX3V1E=; b=IbVDLz3/+KOCtmSv/CJyL6cuUEuIM39EqJgNSDXeFqfJOD4HiJFqNxl0u/80PJcH0GW/+zcKpnrP80/nF3kviTtkczeSltQ9XGFRjo7rxMQMrXcZJ+nAHcGIZuqC2yvH1lgIsBTg0xBJPWEewTTBrOwmNDo9tSsAqlR+PeX69vrVpAjLinoDKflOpE45mB9lP02VuyvDCYsDz/BokfKRZ1chSkYH4ISNMYYnu5YJH406N7F427Sll5ASVAeCUqwVlgzu/G5Uyc1/Sm0tOp4uhiGOnFnpIOki96BPGeD/R6aJzSkcJ1Y1+6EvZ8fUOTUnIX9+qQEif2hYQRCVAEz5Qw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FexDtKWXCey9+yCIyMR6ar2rlrZtG1byR2OU3ep61puXNVvCNHMHli4mmhiK3WdrcrPNDVOR8qucAX6bCHhwIYnw7Ko0/U7JHVkL4Sn+pxeE2mv5DhQbW/8eC8I/2+QJgub8TLYN4oe3drv3ZDDZD+EVsl6TZ+KnvxIX1lvV8i9uZLpnNr8NgE1VNWgpA4YePgpTbwWl7B35rP4noVkcj0vknoo8ESm73lFyjvkNl9WxuEHhzv2qwQDxfjh80EwcmpkblMvMusg9JrX23REulnyQ8KojyfUMJGcgB0p02HG5pgR5afMtB5UoibdcxKJvwgTzIe/Gfs/toZfOdltTeA==
  • Delivered-to: theia-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/theia-dev/>
  • List-help: <mailto:theia-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/theia-dev>, <mailto:theia-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/theia-dev>, <mailto:theia-dev-request@eclipse.org?subject=unsubscribe>
  • Msip_labels:
  • Thread-index: AQHZWBEBD0DQxnkHck+pRs+MKwxkoK79cjnT
  • Thread-topic: [theia-dev] Master breakage
Hi Thomas,

I think the root cause in this case was that the PR had sat a couple of years un-merged, and so had become stale. Ci had passed at the time and there were no merge conflicts, so it looked good to merge. In such a case, I think we should re-trigger CI, which I think would have caught the issue (I think CI tests the PR merged on top of latest master but I am not sure if it would redo the merge upon being re-triggered.  So maybe the PR would need to be uplifted first?)

Regards,
Marc

From: theia-dev <theia-dev-bounces@xxxxxxxxxxx> on behalf of Thomas Mäder <t.s.maeder@xxxxxxxxx>
Sent: Thursday, March 16, 2023 10:09 AM
To: theia-dev@xxxxxxxxxxx <theia-dev@xxxxxxxxxxx>
Subject: [theia-dev] Master breakage
 
Hi folks,

we recently merged https://github.com/eclipse-theia/theia/pull/10338, which seems to have broken master. Mistakes happen, but I'm wondering if we can improve our process? Did the linter check fail and we merged anyway, or is there some technical improvement we can make?

I'd also would encourage anyone who is involved in a "master is broken"-situation to write a quick mail to this very list to alert the community. It keeps everyone with failing PR's from having to investigate what's wrong themselves.

thanks,

/Thomas

Back to the top