[sumo-dev] Strange version handling in SUMO 1.1.0 under ubuntu

[Harald Schaefer <haraldschaefer@xxxxxxxxxxx>]

Dear developers,

it is not possible to install the latest release 1.1.0 build from the sumo-all tar ball without errors.

The install process has three errors like this

- Up-to-date: /usr/local/share/sumo/tools/xml/xsd.py
fatal: Kein Git-Repository (oder irgendein Elternverzeichnis bis zum Einhängepunkt /)
Stoppe bei Dateisystemgrenze (GIT_DISCOVERY_ACROSS_FILESYSTEM nicht gesetzt).
Traceback (most recent call last):
  File "/dosd/src/opensource/Sumo/sumo-1.1.0/tools/build/setup-sumolib.py", line 21, in <module>
    SUMO_VERSION = version.gitDescribe()[1:-11].replace("_", ".").replace("+", ".")
  File "/dosd/src/opensource/Sumo/sumo-1.1.0/tools/build/version.py", line 41, in gitDescribe
    d = subprocess.check_output(command, universal_newlines=True).strip()
  File "/usr/lib/python2.7/subprocess.py", line 223, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['git', 'describe', '--long', '--always', 'HEAD']' returned non-zero exit status 128

It seems that the install routines calls version.py, which in turn calls some git routines, which failed.

My understanding is:

If you create a tar-file for a release x.y.z, i would assume that

the version string x.y.z is hardcoded in one or more files or

the files to compute the version number are included in this tar ball.

You should be able to compile and install from a tar-src file without git or svn or whatever is currently the version management system used.

The generated sumo executable has no version

harald@nyc> ../../bin/sumo --version
Eclipse SUMO Version UNKNOWN
 Build features: Linux-4.18.0-12-generic x86_64 GNU 8.2.0 Release Proj GUI GDAL OSG GL2PS SWIG
 Copyright (C) 2001-2018 German Aerospace Center (DLR) and others; http://sumo.dlr.de

If I build sumo (version 1.0.1) the same way, it has a version string:

harald@nyc> ../../bin/sumo --version
Eclipse SUMO Version 1.0.1
 Build features: Linux-4.18.0-12-generic Proj GUI GDAL OSG GL2PS SWIG
 Copyright (C) 2001-2018 German Aerospace Center (DLR) and others; http://sumo.dlr.de

My proposal is:

When creating a tar file from git, you should copy a file containing the official version for this file (e.g. 1.1.0 or 1.1.0+xxxxxxxxx).

The script version.py reads this file, if it exists, and sets the correct version.

Best regards

Harald

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature