Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [sensinact-dev] JSON library issue
You don't need to re-submit a CQ. 

Add a comment on the CQ [1] asking that the IP Team record that you're modifying the library. They'll add the modified keyword.


On Mon, May 29, 2017 at 3:53 AM, Rémi Druilhe <remi.druilhe@xxxxxxxxx> wrote:
Hi Wayne,

Thanks for the answer. So we modified the JSON library. For now, this library is stored into one of our project sub-module and I think we are going to keep it like that (except if you prefer us to push it into another GIT repository).

However, a question remains. Do we have to re-submit a CQ with the modified code of sensiNact considering the few modifications we had to do to integrate the old JSON library?

Many thanks,

--
Rémi DRUILHE

2017-05-24 22:11 GMT+02:00 wayne beaton <wayne.beaton@eclipse-foundation.org>:
Hi Rémi. 

Just let the IP Team know that the CQ includes the modified keyword. You don't need to inform them of every change.

FWIW, if it makes sense to you and the rest of the project team, you can create a separate Git repository to keep the third-party code and changes isolated.

FYI, I've updated the project metadata so that the project's Git repositories are visible to the community.


Wayne

On Wed, May 24, 2017 at 11:23 AM, Rémi Druilhe <remi.druilhe@xxxxxxxxx> wrote:
I just modified the JSON library to test if it compiles. It seems that we need to do another minor change in the old library to make it work with our current code.

So, back to the point 1., another modification as to be taken into account into the amendment of the library: in the file JSONArray.java, the class should implements Iterable<Object>.

--
Rémi DRUILHE

2017-05-24 10:38 GMT+02:00 Rémi Druilhe <remi.druilhe@xxxxxxxxx>:
Hello Wayne,

Sorry for the late reply. We just had a discussion with Christophe and here is what we agreed to do based on your proposal:

1. We are going to modify the JSON library version 2008-09-18. The file that will be modified will be JSONException.java. The modification is done on line 8, we are changing Exception to RuntimeException. This modification is done to avoid a large refactor of our source code.
2. The new library will be added to our project as any others packages, thus there is no link to the public JSON library because it is embedded.
3. Eclipse will amend the library to consider this minor modification.
4. We will open a low-priority issue to migrate to another JSON library.

I tried to formalize as much as possible the various tasks. If this is okay for you, we will start the first task and continue the IP review.

Just a last question, because we had to do some minor modification to be compliant with Eclipse requirement on some third party libraries, should we create a new IP review of the sensiNact source code? Can we reopen the previous CQ and attach the new code? And, do we need to wait for a new approvement from you to push the code to the Git repository?

Thanks a lot,

Best regards.
--
Rémi DRUILHE


_______________________________________________
sensinact-dev mailing list
sensinact-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/sensinact-dev




--
Wayne Beaton
Director of Open Source Projects
The Eclipse Foundation

_______________________________________________
sensinact-dev mailing list
sensinact-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/sensinact-dev



_______________________________________________
sensinact-dev mailing list
sensinact-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/sensinact-dev




--
Wayne Beaton
Director of Open Source Projects
The Eclipse Foundation

Back to the top