| [riena-dev] ImageStore and Icons with same name |
|
I'm using Riena ImageStore in redView and open-erp-ware Sometimes its a problem, that the icons / images - names must be unique - as far as I understand it, Riena only looks for name of icons into the registered ImagePaths. But if you follow a common naming like http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html this can happen: /icons/16x16/apps/office-calendar.png /icons/32x32/apps/office-calendar.png at the moment I have to rename / relocate like this: /icons/office-calendar-16x16.png /icons/office-calendar-32x32.png I would prefer to slightly modify the ImageStore to handle different pathes with same names, so I opened Bugzilla https://bugs.eclipse.org/bugs/show_bug.cgi?id=300242 the idea is to cache the icons / images into the ImageStore using the symbolic name including the path. per ex. registered ImagePath: /icons image names used: 16x16/apps/office-calendar.png 32x32/apps/office-calendar.png only the method getImageDescriptor(String fullName) needs some more lines to detect if a path is part of the name (see bugzilla) so existing code still works, there are only some lines of code changed if an image wasn't found from cache and a new ImageDescriptor is needed what do you think ? --
ekke (ekkehard gentz) |