Hi Fabian,
Previously, when a class was inserted in the snippet using code proposals, an import section would appear for that class(I guess it’s some basic XText/Xbase behavior). The problem was, that this import section did not respect the template syntax. e.g. in the snippet code, trigger code proposals with ctrl-space. select a class from the proposals list when inserting that class, the import section auto-completed for the class, with the syntax import my.class.example.Class instead of ${imp:import(my.class.example.Class)}
This is not done anymore. Now when triggering code completion for a class, it will complete its fully qualified name, and no import section will appear.
e.g. in the snippet code, trigger code proposals with ctrl-space. select a class from the proposals list when inserting that class, the full qualified name for the class will appear: my.class.example.Class, without any import section.
This brings up the following question: is this a sufficient work-around for the moment? Inserting a class from the code proposals list will no longer insert a bad import section as well, therefor there are no more syntax errors in the snippets caused by this.
Best Regards, Stefan.
Hi Stefan, hi Johannes,
Stefan, I reviewed and merged the two changes. In your other message you said that the 'import auto completion' does not work with that change. As I wrote in the comment on Gerrit, with something like `${imp:import(java.lang.String, java.io.File)}`, the change fixed auto completion on the types for me. Is this what you meant?
Johannes, and is this what you meant about import statements not working correctly in your original message?
Cheers, Fabian Hi Johannes,
I pushed 2 changes on gerrit today, one that re-names the grammar[1] and one to fix the import completion[2]. They are not finished yet.
I will try to look into the Tree - New Tree snippet and fix the problem this evening, but I cannot make any promises.
Hi Stefan, hi Madhuranga, any progress here? I believe fixing the grammar should be the top priority right now, which mostly affects Stefan. bye Johannes Madhuranga Lakjeewa schrieb: Hi, Thank you very much Johannes for pointing out the major issues. I will try to figure out the completion issues you have mentioned.
Thanks, Madhuranga Lakjeewa _______________________________________________
recommenders-dev mailing list
recommenders-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/recommenders-dev
-- Johannes Dorn
Codetrails UG (haftungsbeschränkt) The knowledge transfer company
Robert-Bosch-Str. 7, 64293 DarmstadtTel: +49 6151 2767092
http://www.codetrails.com
Managing Director: Dr. Marcel Bruch Handelsregister: Darmstadt HRB 91940
_______________________________________________ recommenders-dev mailing list recommenders-dev@xxxxxxxxxxxhttps://dev.eclipse.org/mailman/listinfo/recommenders-dev
|