Re: [recommenders-dev] [GSOC 2013] SnipEditor Weekly Report

[Marcel Bruch <marcel.bruch@xxxxxxxxxxxxxx>]

Hi Stefan,

the git repo with the snippets is here [1].
The project is a bundle project which has almost all defined plugins added as required-bundle. But it fails to resolve the SWT types like Button, SWT, Label etc.
Because it's declared as a plug-in project with a dependency to SWT, I expect it to be able to resolve SWT classes. Maybe I'm wrong here?


This email is based on the code a few days ago.

Best,
Marcel


Side note: I frequently get this exception in my log [2]

[1]  git://git.eclipse.org/gitroot/recommenders.incubator/org.eclipse.recommenders.snipmatch.snippets.git
[2] java.lang.NullPointerException
	at org.eclipse.ui.internal.ide.application.IDEWorkbenchWindowAdvisor$1.propertyChanged(IDEWorkbenchWindowAdvisor.java:107)
	at org.eclipse.ui.part.WorkbenchPart.firePropertyChange(WorkbenchPart.java:129)
	at org.eclipse.ui.part.MultiPageEditorPart.handlePropertyChange(MultiPageEditorPart.java:771)
	at org.eclipse.ui.part.MultiPageEditorPart$1.propertyChanged(MultiPageEditorPart.java:246)
	at org.eclipse.ui.part.WorkbenchPart.firePropertyChange(WorkbenchPart.java:129)
	at org.eclipse.ui.texteditor.AbstractTextEditor.firePropertyChange(AbstractTextEditor.java:6379)
	at org.eclipse.ui.part.WorkbenchPart.setTitleImage(WorkbenchPart.java:326)
	at org.eclipse.xtext.ui.editor.XtextEditor.updatedTitleImage(XtextEditor.java:625)
	at org.eclipse.xtext.ui.editor.XtextEditorErrorTickUpdater$1.run(XtextEditorErrorTickUpdater.java:145)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3976)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3653)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:138)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:610)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1426)


On Sep 10, 2013, at 7:09 PM, Stefan Prisca <stefan.prisca@xxxxxxxxx> wrote:

> Hi Marcel,
> 
> The idea of storing the snippets in a repository for the moment sounds good to me.
> 
> On Mon, Sep 9, 2013 at 4:52 AM, Marcel Bruch <marcel.bruch@xxxxxxxxxxxxxx> wrote:
> I also had issues with the classpath being set properly. Maybe we can fix this this week with a higher priority?
> 
> I did not notice any myself, can you please describe the issue so i can look into it?
> 
> 
>  
> Regarding support for ${cursor}:
> Does it make sense to map this statement to any type at all? To me it looks like that this statement (like ${line_selection} and others) should not have any code completion. They should simply be ignored IMHO.
> 
> I tried to leave the type unassigned for this expressions, which results in null types and then the error would change to "Unable to convert null to boolean". If I do not include it at all in the type computer ( I do not provide a method to compute the type for it), then it will give a run-time error saying it cannot compute the type for this expression.
> For the moment i'll leave it as boolean, as it seems to fit everywhere. I will take some time to fix it later on.
> 
> 
> Best Regards,
> Stefan.
> 
> 
> _______________________________________________
> recommenders-dev mailing list
> recommenders-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/recommenders-dev