Re: [recommenders-dev] [snipmatch] deadline awareness

[Chen Cheng <chengchendoc@xxxxxxxxx>]

So, i should submit patches to this repository, you merge the patches
to the trunk, right?

I will learn submit Git patches by Gerrit

2012/4/25, Doug Wightman <douglasw@xxxxxxxxx>:
> Hi Cheng - here's the commit :)
>
> http://git.eclipse.org/c/recommenders/org.eclipse.recommenders.git/commit/?id=761306d5611955def064c21b791448a8c7c6fbe5
>
>
>
> On Sat, Apr 21, 2012 at 4:50 AM, Chen Cheng <chengchendoc@xxxxxxxxx> wrote:
>> Where can i get SnipMatch's source code in Eclipse repository?
>>
>> Then i will compare it with my current repository and create patches.
>>
>>
>> 2012/4/20 Marcel Bruch <marcel.bruch@xxxxxxxxx>
>>>
>>> Yes. First the code needs to be checked in and then small patches should
>>> be created - but only if the small patches make sense. The idea is not to
>>> bypass IP check in general but only require it where needed (not to seed
>>> a
>>> wrong impression on IP ;))
>>>
>>> I identify features like (i) completion popup and (ii) local filesystem,
>>> and maybe (iii) indexing as independent and maybe small enough that they
>>> will probably not violate anyone else's IP. If splitting them into
>>> different
>>> patches does not make sense, go for one patch.
>>>
>>>
>>> On 20.04.2012, at 11:43, Chen Cheng wrote:
>>>
>>> It seems that i shoule compare snipmatch source code here
>>> https://code.google.com/a/eclipselabs.org/p/code-recommenders.kiyomi/
>>> and
>>> code in Eclipse repository, then create many *small* patches to avoid IP
>>> check, finally move the latest version of SnipMatch source code to
>>> Eclipse repository. Right?
>>>
>>> 2012/4/20 Chen Cheng <chengchendoc@xxxxxxxxx>
>>>>
>>>> Hi Marcel & Doug,
>>>>
>>>> What can i do for the deadline?
>>>>
>>>> 2012/4/20 Marcel Bruch <bruch@xxxxxxxxxxxxxxxxxx>
>>>>>
>>>>> Hi Doug,
>>>>> Hi Chen,
>>>>>
>>>>> heads up! ;)
>>>>>
>>>>> I just wanna let you know that we are going to hit some critical
>>>>> deadlines for IP checks that may affect the integration of snipmatch
>>>>> into
>>>>> the JDT package or Juno release train update site.
>>>>>
>>>>> Doug, we really need the sources of snipmatch in the Eclipse repository
>>>>> to enable Chen to create patches against the latest version in the
>>>>> Eclipse
>>>>> repo. If a large patch is coming, the IP team needs to be involved
>>>>> which
>>>>> takes some time. As far as I know the latest time for IP checks is M7
>>>>> (I'll
>>>>> check this deadline with Wayne).
>>>>>
>>>>> Thanks,
>>>>> Marcel
>>>>>
>>>>> --
>>>>> Eclipse Code Recommenders:
>>>>>  w www.eclipse.org/recommenders
>>>>>  tw www.twitter.com/marcelbruch
>>>>>  g+ www.gplus.to/marcelbruch
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> recommenders-dev mailing list
>>>>> recommenders-dev@xxxxxxxxxxx
>>>>> http://dev.eclipse.org/mailman/listinfo/recommenders-dev
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Best Regards From Cheng Chen [chengchendoc@xxxxxxxxx]
>>>
>>>
>>>
>>>
>>> --
>>> Best Regards From Cheng Chen [chengchendoc@xxxxxxxxx]
>>> _______________________________________________
>>> recommenders-dev mailing list
>>> recommenders-dev@xxxxxxxxxxx
>>> http://dev.eclipse.org/mailman/listinfo/recommenders-dev
>>>
>>>
>>>
>>> _______________________________________________
>>> recommenders-dev mailing list
>>> recommenders-dev@xxxxxxxxxxx
>>> http://dev.eclipse.org/mailman/listinfo/recommenders-dev
>>>
>>
>>
>>
>> --
>> Best Regards From Cheng Chen [chengchendoc@xxxxxxxxx]
>>
>> _______________________________________________
>> recommenders-dev mailing list
>> recommenders-dev@xxxxxxxxxxx
>> http://dev.eclipse.org/mailman/listinfo/recommenders-dev
>>
> _______________________________________________
> recommenders-dev mailing list
> recommenders-dev@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/recommenders-dev
>


-- 
Best Regards From Cheng Chen [chengchendoc@xxxxxxxxx]