Re: [platform-ui-dev] Platform contributor guide

[Paul Webster <Paul_Webster@xxxxxxxxxx>]

There's a section on Coding Conventions.  Check  that out.

2 things I see that aren't covered:

1) the unix line delimiters (I thought git handled this on windows)
5) the commit message format:

Bug XXXX - bug title
<space>
Short description of what the fix contains, or the direction of the fix
<space>
Signed-off-by: email-with-CLA


Paul Webster
Eclipse Platform UI Committer
IBM Rational Canada


Lars Vogel ---08/13/2013 07:20:42 AM---Thanks Dani and Paul. Any objection if I add my assumptions about code style to http://wiki.eclipse.org/Platform_UI/How_to_Con

From:	Lars Vogel <lars.vogel@xxxxxxxxx>
To:	"Eclipse Platform UI component developers list." <platform-ui-dev@xxxxxxxxxxx>,
Cc:	platform-ui-dev-bounces@xxxxxxxxxxx
Date:	08/13/2013 07:20 AM
Subject:	Re: [platform-ui-dev] Platform contributor guide

---

Thanks Dani and Paul. Any objection if I add my assumptions about code style to http://wiki.eclipse.org/Platform_UI/How_to_Contribute ? You can afterwards adjust / correct / extend my assumptions. Would be nice to have a place to point to for Gerrit contributions.


2013/8/13 Paul Webster <Paul_Webster@xxxxxxxxxx>

Lars, it's http://wiki.eclipse.org/Platform_UI/How_to_Contribute for Platform UI


Paul Webster
Eclipse Platform UI Committer
IBM Rational Canada


Lars Vogel ---08/13/2013 06:03:24 AM---Thanks Dani, but my question was does platform have a contributor guide? This guide would describe for example the code style

From:	Lars Vogel <lars.vogel@xxxxxxxxx>
To:	"Eclipse Platform UI component developers list." <platform-ui-dev@xxxxxxxxxxx>,
Date:	08/13/2013 06:03 AM
Subject:	Re: [platform-ui-dev] Platform contributor guide

---





Thanks Dani, but my question was does platform have a contributor guide? This guide would describe for example the  code style the platform committer prefer.


2013/8/13 Daniel Megert <daniel_megert@xxxxxxxxxx>
For Git we use http://wiki.eclipse.org/Platform-releng/Git_Workflows 

Dani 


From:        Lars Vogel <lars.vogel@xxxxxxxxx> 
To:        "Eclipse Platform UI component developers list." <platform-ui-dev@xxxxxxxxxxx> 
Cc:        Hendrik Still <Gamma32@xxxxxxxxx> 
Date:        13.08.2013 10:58 
Subject:        [platform-ui-dev] Platform contributor guide 
Sent by:        platform-ui-dev-bounces@xxxxxxxxxxx 


---





Hi,

does platform have a contributor  guide similar to EGit? http://wiki.eclipse.org/EGit/Contributor_Guide 

I'm currently doing and creating some Gerrit reviews and I assume that for platform the following should be used:

1.) uses Unix text line file delimiters
2.) wants to have a copyright preamble
3.) discourages trailing whitespace
4.) prefers the usage of blocks for for/if/while/do statements
5.) Commit message header should be [Bug XXXXX - Bug description from Bugzilla]
6.) @Override should be used (if Plug-in is Java 1.5)

I'm not sure if my assumptions are correct and it would be great to have a wiki page to validate them (or to document them). 

A Google search for "Eclipse platform contributor guide" didn't show up anything and also http://wiki.eclipse.org/Platform does not include a link.

Best regards, Lars
_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev


_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev



_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev

_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev