Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-dev] Github workflow


Am 24. März 2022 14:07:12 MEZ schrieb Aleksandar Kurtakov <akurtako@xxxxxxxxxx>:
>>    1. All the commits should have an issue, created in the same
>>    repository, number associated with them
>>       1. <description of change> #<issue number>
>>
>> I don't think it is necessary to have issues for each commit(more of an PR
>as it may be multiple commits). With Github PR and issue are practically
>the same in terms of references (even share the same number sequence). If
>the concern is that PR is not reopenable it's better to open an issue later
>if there is an actual issue with the PR rather than create really empty
>issues that just hold reference to PR.

That would work for trivial commits. 
For all non trivial ones the problem not to have issue in commits is that there is no other reference to it in git history, so we will miss the context.
Ideally some action could automatically add the full issue/PR url to git commit headers, like gerrit it does.
Is there anything like this for github?
--
Kind regards,
Andrey Loskutov

https://www.eclipse.org/user/aloskutov
Спасение утопающих - дело рук самих утопающих


Back to the top