[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [platform-dev] Deprecating Bugzilla and Gerrrit?
|
> And of course: EGit currently has fairly good integration with Gerrit,
> but none for creating PRs directly from within Eclipse.
I can only tell from my point of view that I never had any need for
toolsupport to create a PR on github while even with Egit Gerrit support
its not always that easy...
Fork Repo > create branch > push changes > click on the create PR link
works with any tool (egit, command line, whatever..) without any
additional setup.
Am 18.12.20 um 10:01 schrieb Thomas Wolf:
On 18.12.20 09:07 , Mickael Istria wrote:
[...]
[On Gitlab vs. Gerrit:]
I think we can just learn new ways here.
Yes, we can. However: triggering CI builds will be different; and I fear
changes in the builds will be required to get them triggered properly.
Reporting build results may also work differently. In any case the
GerritTrigger won't work.
I'm not keen on having to donate more of my volunteer time to revamp CI
builds and their integration with a git server.
[...]
I found that one can easily implement with GitHub similar workflows as
the ones mandated by Gerrit; it's mostly a matter of asking
contributors to put a single commit on their topic branch and to use
`git commit --amend` and `git push --force`, or to squash commits to
modify the branch.
One crucial shortcoming of the PR model of Gitlab/Github is that there
is no support for PRs depending on other PRs. On Gerrit, I very often
have whole sequences of changes that depend on each other. This, and the
ability to group changes by topic, are two crucial features of Gerrit.
Apart from that, Gitlab has a "squash on merge" feature for merging PRs
(or merge requests, as they call it), which makes it easier to deal with
clean-up commits in a PR (no need for amending and force pushing).
Asking contributors to amend and force push means the main benefit of
using a PR model falls away, namely that contributors just know how to
contribute since "everybody" knows the PR model from Github.
And of course: EGit currently has fairly good integration with Gerrit,
but none for creating PRs directly from within Eclipse. There's open
Bugzilla entries for that, but doing that right is quite a bit of work.
So be prepared to find that pushing changes from Eclipse to Gitlab will
be slightly less convenient that just "Push to Gerrit..." for quite a
while.
Cheers,
Thomas
_______________________________________________
platform-dev mailing list
platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/platform-dev
