Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-debug-dev] performApply() in ILaunchConfigurationTab

What I should have added is that if I could detect that this is the first
invocation (due to New button) of performApply()
then I could skip the checks that performApply() do in my code.
In other words if you absolutely need performApply() invocation in New,
then maybe provide a parameter on where it came from ...
Robert.
===========================================================



                                                                                                                       
                    Robert                                                                                             
                    Weisz/Toronto/IBM@IBMCA          To:     platform-debug-dev@xxxxxxxxxxx                            
                    Sent by:                         cc:                                                               
                    platform-debug-dev-admin@e       Subject:     Re: [platform-debug-dev] performApply() in           
                    clipse.org                        ILaunchConfigurationTab                                          
                                                                                                                       
                                                                                                                       
                    04/26/02 06:25 PM                                                                                  
                    Please respond to                                                                                  
                    platform-debug-dev                                                                                 
                                                                                                                       
                                                                                                                       







>When you click New, you are creating a new working copy, setting default
values, and then saving this working copy.  In the course of saving the
>working copy, performApply() is called.  Is this somehow causing you a
problem?

From a user point of view, yes.  See below.

>When you say you get an error dialog clicking New, do you mean a new
dialog separate from the Launch Configuration Dialog, or do you mean >that
an error message appears at the top of the Launch Configuration Dialog?

Thanks for pointing me to the proper area to post the error message,
instead of the separate dialog.  That's what is great about this
forum.

> It is very possible to create a New configuration in circumstances in
which there is not enough information to fill in all required attributes,
>resulting in the Launch Configuration Dialog showing you an error message
that one or more attributes are missing.  This is the expected >behaviour.
>Joe

Yes, and that's where isValid() is very useful, where attributes are
missing altogether.
I would like to use performApply() (as its name implies) to check on the
quality of content of the input when the user presses
the Apply button.
In my example, one field is the process ID of a C/C++ executable that the
user wants to attach to with the debugger.
If the user doesn't put anything there, isValid() will return false, which
disables the Apply button.
Once the user puts something there (and in all other mandatory fields),
the Apply button gets enabled, and the user clicks it.
Now what I would expect is that performApply() is called (now and only now)
and there I check the system to see if that process
id actually runs.  If I cannot find it in the list of running processes, I
will put an error message at the top of the Launch Configuration
Dialog as you mention.   (I guess that performApply() probably needs being
invoked also when the user presses directly Debug
button without pressing Apply button first.  Then I would assume that Apply
is implicit.)

I can see that I could use isValid() to do incremental checking, as each
character is entered on the entry field.
But I can see use for batch processing which performApply() IMHO is
supposed to provide.
(For example if querying the system for running processes and searching for
a match is a time consuming task, then
 using isValid() will be prohibitive from a performance point of view.)

Robert.
===========================================================


   Darin Wright
                          To:        Joe Szurszewski/MIN/OTI@OTI
                          cc:
   04/26/2002             Subject:        Re: [platform-debug-dev]
   12:14 PM       performApply() in ILaunchConfigurationTab





Joe,

Can you comment on these lifecycle calls. Not sure that we need to change
anything, or if this is a required part of the implementation.

Darin

----- Forwarded by Darin Wright/WPG/OTI on 04/26/2002 12:10 PM -----

   weisz@xxxxxxxxxx
   Sent by:                           To:
   platform-debug-dev-admin@e platform-debug-dev@xxxxxxxxxxx
   clipse.org                         cc:
                                      Subject:        Re:
                              [platform-debug-dev] performApply() in
   04/26/2002 12:04 PM        ILaunchConfigurationTab
   Please respond to
   platform-debug-dev




Thanks, the defect clarifies the performApply() called twice on clicking
Apply button.

I still don't know why I get a performApply() on clicking New.  (unless it
is the same problem after all?)

I am using isValid() just to make sure that there is something entered in
the fields, and was
planning on using performApply() to check validity of the contents of all
fields in one shot, at the
time Apply button is pressed, and if something is not right then to popup
an error dialog with specific explanation.

Now when I click New, I get the error dialog since most fields are not
filled with valid data.

Robert.
===========================================================




                   Darin_Swanson@xxxxxxx

                   Sent by:                         To:
platform-debug-dev@xxxxxxxxxxx
                   platform-debug-dev-admin@e       cc:

                   clipse.org                       Subject:     Re:
[platform-debug-dev] performApply() in

ILaunchConfigurationTab

                   04/26/02 12:37 PM

                   Please respond to

                   platform-debug-dev







You have discovered a bug in the implementation logged as

http://bugs.eclipse.org/bugs/show_bug.cgi?id=14758

Thanks
Darins



  weisz@xxxxxxxxxx
  Sent by:                           To:
  platform-debug-dev-admin@e platform-debug-dev@xxxxxxxxxxx
  clipse.org                         cc:
                                     Subject:
                             [platform-debug-dev] performApply() in
  04/26/02 08:52 AM          ILaunchConfigurationTab
  Please respond to
  platform-debug-dev





I implemented a tab for the launch configurations and added it to the tab
group together with the Common tab,
and I seem to get the performApply() invoked three times:
first time as soon as the tab is created, i.e. when I click on New, then
when I click on Apply I get it
again, but instead of once,  I get it twice.

I must be doing something wrong, but I don't know what ...
Any suggestions appreciated.

Robert.
===========================================================

_______________________________________________
platform-debug-dev mailing list
platform-debug-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/platform-debug-dev




_______________________________________________
platform-debug-dev mailing list
platform-debug-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/platform-debug-dev








_______________________________________________
platform-debug-dev mailing list
platform-debug-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/platform-debug-dev





Back to the top