Hi,
I am also good with merging this gerrit. However, I am leaving office, and I am reluctant in committing something with red crosses right before leaving, as I
won’t be aware of issues until tomorrow morning.
So please fill free to commit if you are comfortable with the patches, or I will do it tomorrow morning.
Regards,
Rémi
-------------------------------------------------------
Rémi SCHNEKENBURGER
+33 (0)1 69 08 48 48
CEA Saclay Nano-INNOV
Institut CARNOT CEA LIST
 www.eclipse.org/papyrus
De : papyrus-rt-dev-bounces@xxxxxxxxxxx [mailto:papyrus-rt-dev-bounces@xxxxxxxxxxx]
De la part de Ernesto Posse
Envoyé : mardi 26 juillet 2016 16:28
À : papyrus-rt developer discussions <papyrus-rt-dev@xxxxxxxxxxx>
Objet : Re: [papyrus-rt-dev] Updating terminology (Cont'd)
Good point.
Now I am aware of this change. So, if there is no other solution, I'm good with merging this gerrit.
When the refactoring of the build is completed, we can expect to have *more* of this kind of issue, not less. But that is what (I think) we want: this kind of refactoring
is disruptive to the system design, and so this build structure highlights that. It should help us to reduce the incidence of breaking changes by throwing up Gerrit failures where a monolithic build would not, but when we do need to introduce breaking changes
(as in this case), there will be hoops to jump through.
On 26 July, 2016 at 10:14:22, Ernesto Posse (eposse@xxxxxxxxxxxxx) wrote:
I think the problem is with the codegen pom. The codegen pom does not build the profile, but it has some targetplatform projects as submodules, and I think those include the following, for the nightly and releases TPs:
location "https://hudson.eclipse.org/papyrus-rt/job/Papyrus-RT-Product/lastSuccessfulBuild/artifact/repository/"
{
org.eclipse.papyrusrt.umlrt.profile.feature.feature.group
lazy
org.eclipse.papyrusrt.umlrt.common.ui.feature.feature.group
lazy
org.eclipse.papyrusrt.umlrt.common.feature.feature.group
lazy
org.eclipse.papyrusrt.umlrt.core.feature.feature.group
lazy
}
so I think the build would not work until the updated profile is available at
So it may be necessary to merge this gerrit overriding the -1. I don't know if there is an alternative solution. Perhaps once Celine is done with her reorganization of the build, we won't have this sort of issue.
The codegen build failed again:
[ERROR]
ERROR: UMLRTStateMachProfileUtil.xtend - /jobs/genie.papyrus-rt/Papyrus-RT-CodegenRTS-BuildFrom-gerrit-Master/workspace/source/plugins/xtumlrt/common/org.eclipse.papyrusrt.xtumlrt.external/src/org/eclipse/papyrusrt/xtumlrt/external/predefined/UMLRTStateMachProfileUtil.xtend
10: org.eclipse.papyrusrt.umlrt.profile.statemachine.UMLRTStateMachines.RTTrigger cannot be resolved to a type.
I just realized one thing, though. That plugin's MANIFEST has
org.eclipse.papyrusrt.umlrt.profile;bundle-version="0.7.2",
Has the profile version been updated?
I just rebased it. I'll push it to Gerrit and hopefully it will work.
Hi Ernesto,
Thank you very much. Let me know if you have any question /feedback
Regards
Rémi
-------------------------------------------------------
Rémi SCHNEKENBURGER
+33 (0)1 69 08 48 48
CEA Saclay Nano-INNOV
Institut CARNOT CEA LIST
www.eclipse.org/papyrus
Hi Remi. I did see that failure and commented on Gerrit. The codegen build fails because it cannot find the UML-RT state machines profile. After a closer look, it looks like the
issue is that that one has been renamed from UMLRealTimeStateMach to UMLRTStateMachines.
I'll get the gerrit and fix the references.
Hi team,
I pushed a new version of the contribution that sounds OK for me, but not for some of the gerrit jobs, especially the codegen one [1]. However, when I look to the compilation errors,
it seems that it only comes from the fact that the profile plugin used for building the gerrit is not up-to-date.
So, I have again 2 choices:
- Ignoring the gerrit from codegen, and pushing the gerrit. Then I could ensure that the main builds stay green. In this case, and if I cannot solve the issues fast, I could revert the commit and work locally again
on it.
- Ask for a local review from Ernesto or any other people involved in the codegen part to check if everything is fine, and then only commit.
What do you think? I am reluctant to override the -1 from a reviewer on gerrit, but I know in this case that we are in a deadlock :/
Regards,
Rémi
[1]
https://hudson.eclipse.org/papyrus-rt/view/Gerrit/job/Papyrus-RT-Gerrit-master/567/
-------------------------------------------------------
Rémi SCHNEKENBURGER
+33 (0)1 69 08 48 48
CEA Saclay Nano-INNOV
Institut CARNOT CEA LIST
www.eclipse.org/papyrus
_______________________________________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt-dev
_______________________________________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt-dev
_______________________________________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt-dev
_______________________________________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt-dev
|
