Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [papyrus-rt-dev] [Codegen] Move the folder one level up

Hello Ernesto,

I'm working on a change based on Camille's gerrit...

I'll let you know when I need your review.

Regards


Le 18/05/2016 à 15:42, Ernesto Posse a écrit :
I'm with Camille on this one. I've argued for a long time that we should have a unified build, while still being able to do separate builds for codegen+rts on one hand and core+profile+tooling on the other. In fact, Cemille's gerrit 70225 already goes some way in this direction.

I'm not familiar enough with maven to know how this could be done, but in theory I think that codegen should indeed be a module and somehow we could activate a codegen-only build or a tooling-only build. Looking at Camille's changes to releng/codegen/pom.xml in that gerrit it looks like with that we could enable a codegen-only build, although I don't see how we could enable a tooling-only build.

Note, however, that for this unified build to work, we need to make a couple of updates in our codegen scripts, as shown in the gerrit.

PS: I'm fine with changing the codegen artifact id to follow the same pattern as the rest. Feel free to make that change.

 

On Wed, May 18, 2016 at 5:11 AM Céline JANSSENS <celine.janssens@xxxxxxxxxxx> wrote:

Hi Camille,

I understand your concerns, but for the time being the codegen pom has no parent. It is considered as a main pom, exactly like the releng pom.

A root pom will be created at the main project level (artifact id would be: org.eclipse.papyrusrt.parent) , maybe should I add the codegen pom (umlrt.code-generator)* as a module of this new pom ?

*BTW: it would be nice to homogenize the pom artifact id of the codegen which is quite singular. But there could be side effects ?!


Le 18/05/2016 à 10:19, LETAVERNIER Camille a écrit :

Hi,

 

Codegen and Papyrus-RT should still be unified with a Common parent [1]. The reason is that they share a lot of common things:

 

-          Some common dependencies (At least between the Papyrus-RT profile and the Codegen plug-ins). A common “abstract” TP is required to ensure that we don’t introduce any version conflict (It is even more important, as Papyrus-RT is not in the release train, so it doesn’t benefit from the strict validation of versions compatibility)

-          It is possible to use several Target Platforms in a single build. Papyrus uses 5 different TPs referencing each other, and still has a parent POM which can be built in one pass.

 

There are also a few other points to take into account:

 

-          Having a different layout for Codegen compared to other Features doesn’t seem a good idea. If you want to enforce conventions, then they need to be consistent. Also, be careful about Maven conventions; you’ll often find out that they are contradicting Eclipse and/or OSGI conventions

-          Changing the conventions for a specific project is not a decision to be taken lightly. Changing the file structure will make it very difficult for Git/EGit/Gerrit to work properly

 

[1] 70225: Bug 469722: [Releng] Configure Maven build for Papyrus-RT

https://git.eclipse.org/r/#/c/70225/

 

Regards,
Camille

 

De : papyrus-rt-dev-bounces@xxxxxxxxxxx [mailto:papyrus-rt-dev-bounces@xxxxxxxxxxx] De la part de Céline JANSSENS
Envoyé : mercredi 18 mai 2016 09:49
À : papyrus-rt developer discussions <papyrus-rt-dev@xxxxxxxxxxx>; papyrus@xxxxxxxxxxx
Objet : [papyrus-rt-dev] [Codegen] Move the folder one level up

 

Hello team,

It is required to simplify the herarchy of the project to make it align with the maven purpose. [1]

In this goal, I think to move the "codegen" folder one level up, as the sibling of the releng folder.
Why such a decision? Because the codegen is not built into the releng/pom.xml anymore, and the codegen has now it's own Target platform to be run separately though the Hudson Job.

Thus, I would like to have your opinion for this modification as I'm not used to work with the "codegen" of this project.

[1] - https://bugs.eclipse.org/bugs/show_bug.cgi?id=493864

--

 

 

 

Céline JANSSENS
Software Engineer
+33 (0)2 44 47 23 23

 

Mail : cej@xxxxxxxxxxx

6 rue Léonard De Vinci - BP 0119 - 53001 LAVAL Cedex - FRANCE
www.all4tec.net

 



_______________________________________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt-dev

--

 
  Céline JANSSENS
 Software Engineer
+33 (0)2 44 47 23 23
  Mail : cej@xxxxxxxxxxx
6 rue Léonard De Vinci - BP 0119 - 53001 LAVAL Cedex - FRANCE
www.all4tec.net
_______________________________________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt-dev


_______________________________________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt-dev

--

 
  Céline JANSSENS
 Software Engineer
+33 (0)2 44 47 23 23
  Mail : cej@xxxxxxxxxxx
6 rue Léonard De Vinci - BP 0119 - 53001 LAVAL Cedex - FRANCE
www.all4tec.net

Back to the top