Actually. as Benjamin states earlier in the thread, there is no such
restriction.
If the commit's author has a signed CLA and the commit message
contains a "signed-off-by" entry, you can accept the pull request
per the IP Due Diligence process (e.g. you might need a CQ if the
contribution is > 1000).
Just cherry pick the commit out of the source repo.
HTH,
Wayne
Sent: Friday, April 24, 2015 4:38 AM
To: General development discussions for
paho project
Reply To: General development discussions
for paho project
Subject: Re: [paho-dev] paho Android
Service and Sample App with Gradle
|
Hi Ian,
alright I will look into this next week.
Sandro
Hi
Sandro,
sorry, somehow I missed your previous message in
March. Unfortunately at the moment we have
limitations on accepting pull requests on github,
because the Eclipse process/legal procedures are not
geared up for that.
I and others have made it known to the Eclipse
organization that it would help us to get more
contributions if we could integrate more closely
with github, so I'm hoping we'll get progress, but
probably not any time soon.
If you can submit via Gerrit that would be really
helpful.
Ian
On 04/23/2015 08:19 AM,
Sandro Kock wrote:
Any updates on this? I know it might be a bit
difficult to merge a PR made to Github but it
would encourage contribution to the project. If it
helps I can look into the steps described on [1]
and try them to see if they all work out..
Thanks,
Sandro
[1] https://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions#Git
Hi,
any updates on this? I
can just submit my changes via
Gerrit if this helps.
Thanks,
Sandro
Github
pull requests are
perfectly fine, but
they are usually meant
to be used with
Eclipse projects that
have their repos hosted on
Github. Such repos
have dedicated hooks
that easily allow to
check if the commits
in the proposed PR are
from a committer with
a valid CLA in place.
A similar check is
happening when a PR is
submitted via Gerrit.
HTH
Benjamin –
Benjamin
Cabé
Eclipse
Foundation
+33
(0) 619196101
Hi Sandro
(and Jeff),
it's not a problem
for me to accept
your idea -- I thank
you for making the
contribution :-)
So, Benjamin might
correct me here, but
it's my
understanding that
we can't currently
accept contributions
via github pull
requests. They
have to be via
Eclipse bugzilla or
Gerrit, because of
the Eclipse IP/legal
process. I also
believe that this is
something the
Eclipse Foundation
is looking into, but
that any solution
isn't necessarily
simple or likely to
happen soon.
Benjamin?
Ian
On
02/27/2015 03:30
PM, Sandro Kock
wrote:
Hi,
I
have submitted
my pull request
via github [1],
if it is easier
is can submit it
to [2].
Sandro
Hey
guys,
Thanks
Ian for
acceping our
idea.
I
didn't changed
any
functionality.
I only changed
it to Android
Studio be able
to open it
easily. If you
have any more
improvements
feel free to
submit your
version. If
you have any
questions
don't hesitate
to contact me.
Best!
-Jeff
Prestes
_______________________________________________
paho-dev
mailing list
paho-dev@xxxxxxxxxxx
To change your
delivery
options,
retrieve your
password, or
unsubscribe
from this
list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev
_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev
--
Ian Craggs
icraggs@xxxxxxxxxx IBM United Kingdom
Paho Project Lead; Committer on Mosquitto
_______________________________________________
paho-dev
mailing list paho-dev@xxxxxxxxxxx To
change your delivery
options, retrieve your
password, or unsubscribe
from this list, visit https://dev.eclipse.org/mailman/listinfo/paho-dev
<64BFBB6C-FC2D-4129-971F-33935977CC64[28].png>_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery
options, retrieve your
password, or unsubscribe from
this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev
_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev
--
Ian Craggs
icraggs@xxxxxxxxxx IBM United Kingdom
Paho Project Lead; Committer on Mosquitto
_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your
password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev
--
Wayne Beaton on behalf of the Eclipse Management Organization
@waynebeaton
The Eclipse Foundation
|
