Re: [paho-dev] C client changes from 1.0 to master

[Roger Light <roger@xxxxxxxxxx>]

Hi Ian,

That looks good to me.

Cheers,

Roger



On Thu, Oct 9, 2014 at 2:59 PM, Ian Craggs
<icraggs@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> Hi Roger,
>
> what I've actually done is create 1.0.2 by leaving in the "const" additions,
> adding the "const" omissions you spotted, and removing the size_t changes
> (for later).
>
> Which I hope is acceptable :-)
>
> Ian
>
>
>
> On 09/28/2014 10:44 AM, Roger Light wrote:
>>
>> Hi Ian,
>>
>> That sounds like a good plan.
>>
>> I very nearly got caught out with a similar thing with a contribution
>> via gerrit for the python client. Only at the last minute did I
>> realise it should have been on a different branch. Which reminds me -
>> I need to review it.
>>
>> Cheers,
>>
>> Roger
>>
>>
>> On Fri, Sep 26, 2014 at 5:57 PM, Ian Craggs
>> <icraggs@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
>>>
>>> Hi Roger,
>>>
>>> thanks for reviewing these changes.  Unfortunately I was in a rush to get
>>> a
>>> timing fix out for 1.0.1 and hadn't cleanly separated the updates -
>>> resulting in this.
>>>
>>> Next week, I'll see if I can roll back the external API changes in the
>>> master branch, leaving the internal fixes, and produce a 1.0.2.
>>>
>>> The API changes (which will not cause any application code to be changed)
>>> can then be incorporated into a 1.1 release properly.
>>>
>>> Ian
>>>
>>>
>>>
>>> On 09/26/2014 01:57 PM, Roger Light wrote:
>>>>
>>>> Hi,
>>>>
>>>> I just had a look at some of the changes in the normal C client
>>>> between 1.0 and master and had some comments.
>>>>
>>>> There were a large number of char * -> const char * changes
>>>> introduced. The MQTTAsync_SSLOptions struct in MQTTAsync.h had all of
>>>> its char members converted to const, but the corresponding
>>>> MQTTClient_SSLOptions struct in MQTTClient.h didn't. I presume this
>>>> was a simple oversight.
>>>>
>>>> The interface of the functions below was changed from (..., int, ...)
>>>> to (..., size_t, ...), but again only changed MQTTAsync and not
>>>> MQTTClient. This is a binary incompatible change, so the SO version
>>>> number of the libraries needs incrementing. Unfortunately the change
>>>> was included in the v1.0.1 release, which means that v1.0 and v1.0.1
>>>> of the async client may be incompatible, depending on the platform
>>>> being used.
>>>>
>>>> Cheers,
>>>>
>>>> Roger
>>>> _______________________________________________
>>>> paho-dev mailing list
>>>> paho-dev@xxxxxxxxxxx
>>>> To change your delivery options, retrieve your password, or unsubscribe
>>>> from this list, visit
>>>> https://dev.eclipse.org/mailman/listinfo/paho-dev
>>>
>>>
>>> --
>>> Ian Craggs
>>> icraggs@xxxxxxxxxx                 IBM United Kingdom
>>> Paho Project Lead; Committer on Mosquitto
>>>
>>> _______________________________________________
>>> paho-dev mailing list
>>> paho-dev@xxxxxxxxxxx
>>> To change your delivery options, retrieve your password, or unsubscribe
>>> from
>>> this list, visit
>>> https://dev.eclipse.org/mailman/listinfo/paho-dev
>>
>> _______________________________________________
>> paho-dev mailing list
>> paho-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/paho-dev
>
>
> --
> Ian Craggs
> icraggs@xxxxxxxxxx                 IBM United Kingdom
> Paho Project Lead; Committer on Mosquitto
>
> _______________________________________________
> paho-dev mailing list
> paho-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/paho-dev