Re: [paho-dev] Tabs vs. spaces in the codebase

[Andy Piper <andypiperuk@xxxxxxxxx>]

I believe Eclipse Coding Conventions (which obviously have a Java slant historically) are based on Sun's: http://wiki.eclipse.org/Coding_Conventions

"We indent with tabs, 4 spaces wide" - which I interpret to mean tabs should be 4 space character, not a tab character.

#needsfixing

On Wednesday, November 13, 2013, Michael Klishin wrote:

While working on [1], I've noticed that different
parts of the codebase use tabs, while some use spaces.

Have the Paho team considered settling on either option
and enforcing it?

This is not a top priority issue but it makes it life of patch reviewers harder

*and* makes it harder for contributors to make sure your patch has a good
signal/noise ratio.

1. https://github.com/michaelklishin/paho.mqtt.java/compare/mk-uri-parsing-improvements

--
MK

http://github.com/michaelklishin
http://twitter.com/michaelklishin

--

Andy Piper | Kingston upon Thames, London (UK)
blog: http://andypiper.co.uk   |   skype: andypiperuk
twitter: @andypiper  |  images: http://www.flickr.com/photos/andypiper