[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [openmq-dev] About PR #609 - final javax->jakarta in comments
|
I approved this. Wasn't sure if you wanted it merged before or after we
complete the M2 release. Let me know if you would like me to merge it
now, or if you have permission now, go ahead and click merge yourself!
(Yay! congrats! And thank you for stepping up!)
-- Ed
On 10/20/2020 12:18 AM, Piotr Żygieło wrote:
Hello Team
Firstly - thank you for the just completed election. Jonathan and
Steve - for initial support, Ed, Committers, PMC for voting and
approval.
The https://urldefense.com/v3/__https://github.com/eclipse-ee4j/openmq/pull/609__;!!GqivPVa7Brio!LV6b51hrJ9VT-df3u1eUnfe5dVGY7afLIxja8dTESEVNma9VS7zQMBn4q8IkH-k$ is not even
cosmetic, as all changes proposed are in comments for private methods,
so by default they do not appear in javadocs.
As not visible to end-user and having no impact on the code I think
it's extremely safe - and then
** I'd like to merge this PR#609 **
if no changes are requested.
I'm bothering you only as this would be my first merge in EE4J and for
my own PR, so it feels kind of strange...
