Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mylyn-dev] How to replace PersonProposalProvider?

Thanks, worked fine this time.

What do I need to know about this installation? 
How is it customized for Mylyn?

   George

On 2022-12-22 02:50, Wim Jongman wrote:
George, this was fixed. Please try again.


On Wed, 21 Dec 2022 at 19:17, George Lindholm <javadev@xxxxxxxxxxxx> wrote:
I was trying to set up a mylyn development environment so I could work on PersonProposalProvider

George


On 2022-12-21 06:39, Frank Becker (Eclipse) wrote:
How is the error from the png related to the PersonProposalProvider?

Can we create an issue and discuss there?

Regards 
Frank

Am 20.12.2022 um 20:51 schrieb Wim Jongman <wim.jongman@xxxxxxxxx>:

Yes, I get the same issue in Nebula. Ed, does this ring a bell?

Cheers,

Wim

On Tue, 20 Dec 2022 at 20:43, George Lindholm <javadev@xxxxxxxxxxxx> wrote:
I tried the first launch option got this error:
<hvUwDwQrKJEHzR3o.png>

  George
On 2022-12-19 13:11, George Lindholm wrote:
Hi,
  the first one is an easy fix. I'll do that

The point about the 'id' requires a new design since the interface between PersonProposalProvider and the connector is
through a Map<String, String>, when probably should be a List<IRepositoryPerson>

   George
On 2022-12-19 09:33, Alexander Fedorov wrote:
Hi,

If you already know the exact code to fix why not to make the next step?
Would you mind to create an issue so we can discuss the proposed changes in details?
If it could be followed by PR then it would be fantastic.

Here is the how to contribute guide https://github.com/eclipse-mylyn/.github/blob/main/CONTRIBUTING.md

Regards,
AF

12/19/2022 8:21 PM, George Lindholm пишет:
On 2022-12-19 04:16, Wim Jongman wrote:
Do you mean in an existing connector or in a connector that you are going to make yourself.

In general, but at the moment for my jira connector.

There are some problems with PersonProposalProvider that I would like to address.

The one that is affecting me the most at the moment is 'matchesSubstring()' which is doing  'startsWith()' instead of 'contains()'

Other problems that I'm able to work around, but is ugly, is the assumption that the 'id' is has human attributes associated with it.
This is fine when the id is an account which, most/some of the time, can be directly associated with a person, but with
Jira Cloud the id is a random string of characters, and offering them as an select option is meaningless.
'getPrettyName()' also suffers from this assumption.

Thanks
   George

Cheers, Wim

On Fri, 9 Dec 2022 at 08:57, George Lindholm <gnl@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
Hi,
   is there any way to use my own version of the PersonProposalProvider
in a connector?
The current one has some issue I would like to work around

Thanks
    George
_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-dev

_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-dev


_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-dev


_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-dev


_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-dev

_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-dev
_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-dev


_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-dev

_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-dev

_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-dev


Back to the top