Re: [m2e-users] Maven test classes are visible to WTP

[Andrew Eisenberg <andrew@xxxxxxxxxxxx>]

Hi Fred,

Yep.  Thanks for checking this out.  looks like upgrading to 0.15.0
did the trick.

On Wed, Mar 7, 2012 at 5:53 PM, Fred Bricon <fbricon@xxxxxxxxx> wrote:
> Andrew, the test case in  https://jira.codehaus.org/browse/GRECLIPSE-1372
> deploys properly with STS 2.9.0 since it embeds m2e-wtp 0.15.0.
> You'll need to import as maven project or make sure "update project
> configuration" is invoked for the test folders to be removed from
> .component.
>
> Fred Bricon
>
>
> On Thu, Mar 8, 2012 at 1:53 AM, Fred Bricon <fbricon@xxxxxxxxx> wrote:
>>
>> If you look at
>> https://github.com/sonatype/m2eclipse-wtp/blob/master/org.maven.ide.eclipse.wtp/src/org/maven/ide/eclipse/wtp/WTPProjectsUtil.java#L508
>> you'll see we remove ANY folder mapped to the test output directory. Are
>> you sure you're using m2e-wtp 0.15.x?
>>
>> As long as you're patch doesn't have groovy stuff hardcoded everywhere,
>> please be my guest :-)
>>
>> Fred Bricon
>>
>>
>> On Thu, Mar 8, 2012 at 1:19 AM, Andrew Eisenberg <andrew@xxxxxxxxxxxx>
>> wrote:
>>>
>>> Hi Fred,
>>>
>>> Thanks for the fast response.  The github links make it clear what is
>>> happening.  WTP is checking the maven model for the test folders to
>>> remove, but the Groovy-Eclipse project configurator and the
>>> groovy-eclipse-compiler do not add these folders to the maven model in
>>> the usual way.
>>>
>>> I'll see if removing those entries from the UI will fix the problem.
>>>
>>> But also, would you accept a patch that augments the
>>> removeTestFolderLinks method such that the groovy-eclipse situation is
>>> handled appropriately?  Seems like it would be a fairly straight
>>> forward thing to do.  Thanks.
>>>
>>> On Wed, Mar 7, 2012 at 3:58 PM, Fred Bricon <fbricon@xxxxxxxxx> wrote:
>>> > Hi Andrew,
>>> >
>>> > WTP deploys what's under the Deployment Assembly property page of your
>>> > project (fancy UI over .settings/org.eclipse.wst.common.component)
>>> >
>>> > In the case of m2e-wtp , we *manually* remove the test output from
>>> > deployment during project configuration. See :
>>> >
>>> > https://github.com/sonatype/m2eclipse-wtp/blob/master/org.maven.ide.eclipse.wtp/src/org/maven/ide/eclipse/wtp/WebFragmentProjectConfigurator.java#L102
>>> >
>>> > and :
>>> >
>>> > https://github.com/sonatype/m2eclipse-wtp/blob/master/org.maven.ide.eclipse.wtp/src/org/maven/ide/eclipse/wtp/WTPProjectsUtil.java#L492
>>> >
>>> > HIH
>>> >
>>> > Fred Bricon
>>> >
>>> > On Thu, Mar 8, 2012 at 12:51 AM, Andrew Eisenberg <andrew@xxxxxxxxxxxx>
>>> > wrote:
>>> >>
>>> >> Hi all,
>>> >>
>>> >> I'm working through this issue and have hit a bit of a wall.
>>> >> https://jira.codehaus.org/browse/GRECLIPSE-1372
>>> >>
>>> >> I'm hoping that someone familier with WTP's M2E integration can help
>>> >> me
>>> >> further.
>>> >>
>>> >> When scanning a classpath, WTP is including test classes in the
>>> >> deployed application.  This only happens when using Groovy-Eclipse M2E
>>> >> integration, so there must be some kind of conflict there.
>>> >>
>>> >> How does WTP determine what should be deployed?  Can someone point me
>>> >> to some code that does this?
>>> >>
>>> >> thanks,
>>> >> Andrew
>>> >> _______________________________________________
>>> >> m2e-users mailing list
>>> >> m2e-users@xxxxxxxxxxx
>>> >> https://dev.eclipse.org/mailman/listinfo/m2e-users
>>> >
>>> >
>>> >
>>> >
>>> > --
>>> > "Have you tried turning it off and on again" - The IT Crowd
>>
>>
>>
>>
>> --
>> "Have you tried turning it off and on again" - The IT Crowd
>
>
>
>
> --
> "Have you tried turning it off and on again" - The IT Crowd