thanks a lot for your feedback.
I tried the signature tests and found some minor issues:
- It works with Java 8, but I ran into some issues because I only had Java 11 installed, which is missing the rt.jar. Is there a workaround - I don’t like having to install an outdated copy of Java 8 ;-)
I also had issues with Java 11. But as we require Java 8 for MVC 1.0, I guess the user should also use Java 8 for running the signature tests. I'll add a corresponding note to the documentation.
BTW: AFAIK the sigtest tool doesn't work at all with newer java versions. The TCK documentation also recommends a "dev" version of the tool. Unfortunately I wasn't able to find newer versions of it anywhere. :-(
- After downloading the sigtest-tool it doesn’t mention that you should unzip it (I know it’s silly - I just switched my brain off and copy pasted the commands).
There is an "unzip" command in the "Obtaining the sigtest tool" section and it also notes that the user should "download and unpack it". Maybe you just missed this one?
- We run the test against the javaee-api. Should we switch to Jakarta instead?
Good question. Actually we target Java EE 8 and not Jakarta EE 8. But they are equivalent. I just thought that as we submit the material to the JCP which was used to specify Java EE 8 back then, Java EE would be the better choice. However, I'm not really sure what the best choice is here. :-)
- If the sonatype URLs don’t work why SNAPSHOT? Why not put the final URLs there and safe as another update?
I use Asciidoc variables to generate the URLs from the version specified in the pom. So ideally I can just do the release (which updates the pom version) and the URLs will reflect exactly the version required. However, I agree that for the snapshot version this is not optimal, because the URL will never work. Not sure if there are if-like constructs in Asciidoc which would allow to fix this by using Maven Central for non-snapshot versions and the Sonatype Snapshot repo for snapshot versions.
So it’s just really minor stuff. Feel free to send it to the JCP!
Thanks for your review! :-)
