[jta-dev] Requesting further review on https://github.com/jakartaee/tran

[Tom Jenkinson <Tom.Jenkinson@xxxxxxx>]

Hi,

Please can I ask for further reviews on https://github.com/jakartaee/transactions/pull/226?

[#225] introduce Transaction.Status enum and deprecate Status by gavinking · Pull Request #226 · jakartaee/transactions also give Synchronization default noop impls of its methods for #225 github.com

The change looks good to me and I have already approved it so if discussion hasn't shown up blockers before then I will go ahead and merge it. Thank you to Gavin for proposing the issue (https://github.com/jakartaee/transactions/issues/225) and raising a pull request for it.

Status should be an enum · Issue #225 · jakartaee/transactions Java has had enum for, well—I don't recall exactly—but all of the current millennium, I guess. Until quite recently, enum s weren't especially worth the effort because the Java compiler treated them in a pretty stupid way, but recent version of the Java language finally introduce proper coverage analysis in switch expressions, making enum actually useful for something. JTA's Status is an ... github.com

Thank you to our community for any reviews/feedback that you can provide,

Tom

Unless otherwise stated above:

IBM United Kingdom Limited
Registered in England and Wales with number 741598
Registered office: Building C, IBM Hursley Office, Hursley Park Road, Winchester, Hampshire SO21 2JN