Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jta-dev] Input requested: Formatting changes in pull requests
Thank you, Hantsy I think that is a +1 to having formatting changes guarded against. There has not been enough feedback on the discussion for me to have a sense that the committers feel strongly one way or another on this topic I will mention that I intend to merge https://github.com/jakartaee/transactions/pull/230 without such a kind of restriction in place.

On Wed, 11 Jun 2025 at 02:36, hantsy bai <hantsy@xxxxxxxxx> wrote:
Add commitlint in the Git hooks and Github actions.

---

Regards,

Hantsy Bai

Self-employed consultant, fullstack developer, agile coach, freelancer/remote worker

GitHub: https://github.com/hantsy

Twitter: https://twitter.com/@hantsy

Medium: https://medium.com/@hantsy


On Wed, Jun 11, 2025 at 12:37 AM Tom Jenkinson via jta-dev <jta-dev@xxxxxxxxxxx> wrote:
Hi,

Ideally I would like to have a sense from the project committers [1] if we are fine to accept code formatting changes in pull requests and if so, whether we would like to put any guidelines (e.g. separate commit) in place for that type of change?

Community perspective is welcome to be shared too.

Thank you,
Tom



--

Tom Jenkinson

He / Him / His

Director, Software Engineering

EAP (Application Runtimes)

Red Hat

tom.jenkinson@xxxxxxxxxx   

_______________________________________________
jta-dev mailing list
jta-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jta-dev

Back to the top