Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jsp-dev] Debugging 2.0 and Pages 3.0 Spec PR Drafts (further discussion/actions necessary)
Hi,

For all the specs I've created PRs for, I simply copy whatever is in [api project]\target\apidocs to the apidocs folder of the PR in question. Indeed as Hussain mentioned using whatever JDK happens to be on my system at the time.

Kind regards,
Arjan


On Tue, Sep 29, 2020 at 6:55 AM <Hussain.NM@xxxxxxxxxxxxx> wrote:

If the apidocs were generated with JDK9+ then it will contain jquery for search functionality. You can replace the whole directory of apidocs with your current version.

 

Currently we do not have any guidance on which JDK version needs to be used build apidocs. Each project is generating the apidocs with whatever JDK is available on their system (ranging from 8-15).

 

Thanks

Hussain

 

From: jsp-dev-bounces@xxxxxxxxxxx <jsp-dev-bounces@xxxxxxxxxxx> On Behalf Of Paul Nicolucci
Sent: Tuesday, September 29, 2020 9:31 AM
To: jsp developer discussions <jsp-dev@xxxxxxxxxxx>
Subject: [jsp-dev] Debugging 2.0 and Pages 3.0 Spec PR Drafts (further discussion/actions necessary)

Hello,

 

I started the specification PR drafts tonight:

 

Debugging 2.0:

  1. mvn clean install -Pstaging -Dstatus=Final
  2. Updated jdsol-spec/pom.xml to specify <version>2.0</version> instead of <version>2.0-SNAPSHOT</version>
  3. https://github.com/eclipse-ee4j/jsp-api/issues/130 updated this issue with a link to the specification PR: https://github.com/jakartaee/specifications/pull/279
  4. Since there are no APIs I think we're looking good on this one.


Pages 3.0:

 

  1. mvn clean install -Pstaging -Dstatus=Final
  2. updated spec/pom.xml to specify <version>3.0</version> instead of <version>3.0-SNAPSHOT</version>
  3. https://github.com/eclipse-ee4j/jsp-api/issues/129 updated this issue with a link to the specification PR: https://github.com/jakartaee/specifications/pull/280
  4. For the TCK links looking at the directory structure I took a best guess approach as to what the final links will be.
  5. I updated the Compatible implementation to  Apache Tomcat 10.0.0-M8 which looks to be the latest version available.
  6. We will need to get the apidocs up for this PR however I have some questions that I'll outline below.

 

APIDoc Questions:

 

  1. The directory structure of jsp-api\api\target\apidocs does not seem to match the directory structure of specifications\pages\3.0\apidocs. Mainly I see the jquery/resources directories are missing in the specification file tree.
  2. Do we just copy the entire jsp-api\api\target\apidocs directory structure into the specifications directory or are there certain files that should be avoided? I'm just looking for some guidance here as this is the first I've created these PRs.

 

Any other comments/suggestions/concerns?

 

Thanks,

 

Paul Nicolucci






* We will need the apidocs to be added in another PR or perhaps I can do it as part of this
PR but I have a couple of questions.

This e-mail and any files transmitted with it are for the sole use of the intended recipient(s) and may contain confidential and privileged information. If you are not the intended recipient(s), please reply to the sender and destroy all copies of the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email, and/or any action taken in reliance on the contents of this e-mail is strictly prohibited and may be unlawful. Where permitted by applicable law, this e-mail and other e-mail communications sent to and from Cognizant e-mail addresses may be monitored. This e-mail and any files transmitted with it are for the sole use of the intended recipient(s) and may contain confidential and privileged information. If you are not the intended recipient(s), please reply to the sender and destroy all copies of the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email, and/or any action taken in reliance on the contents of this e-mail is strictly prohibited and may be unlawful. Where permitted by applicable law, this e-mail and other e-mail communications sent to and from Cognizant e-mail addresses may be monitored.
_______________________________________________
jsp-dev mailing list
jsp-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jsp-dev

Back to the top