Re: [jgit-dev] RemoteAddCommand chaining

[Mincong Huang <mhuang@xxxxxxxxx>]

I guess the email didn't send because I wasn't subscribed to JGIt mailing list.

On Wed, May 30, 2018 at 2:41 PM, Mincong Huang <mhuang@xxxxxxxxx> wrote:

Hi,

I just discovered that command `org.eclipse.jgit.api.RemoteAddCommand` does not allow method chaining. Currently, I need to do:

    RemoteAddCommand command = git.remoteAdd();

    command.setName("origin");

    command.setUri(new URIish(myUrl));

    command.call();

​Do you think it worth to change it into method chaining? This change will be backward compatible.​ The version used is 4.11.0.201803080745-r.

I'm new to JGit but I'd like to submit a patch if possible :)

​

​Best,​

--

Mincong Huang Software Engineer  Nuxeo Content Services Platform. Stay ahead.