Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jgit-dev] JGit's overuse of IOException

I do not have a specific proposal, but I wish the server side code (e.g. org.eclipse.jgit.transport.UploadPack,ReceivePack) can make use of RuntimeException derived classes more. Basically the server cannot do any exception recovery when an exception happens, and the code anyway ends up with writing an ERR packet. Then, propagating checked exceptions doesn't that make sense. If there is an exception hierarchy change (and it probably means exception handling policy change), it's nice if there are RuntimeException derived exceptions for the server-side code.

(Also this is a minor thing, but the server code somehow catches java.lang.Error. I think we should not catch Error subclasses in applications in general.)

--
Masaya Suzuki
draftcode@xxxxxxxxx

On Tue, May 22, 2018 at 10:49 AM, Matthias Sohn <matthias.sohn@xxxxxxxxx> wrote:
On Tue, May 22, 2018 at 7:13 PM, Jonathan Nieder <jrn@xxxxxxxxxx> wrote:
Hi,

Thomas Wolf wrote:

Some clean-up is in order, but it’s probably not going to
be easy. Targeting 5.0 even for deprecations is probably a bit
ambitious — that’s just one month away.

Fully agreed --- sorry I didn't make that clearer. There's no hurry.

ok, let's target this post 5.0

I propose we move the remaining work for 5.0 to the stable-5.0 branch
after I tagged our contribution to Photon RC1, I'll try to tag that later today.
 
I have a bad habit of not paying attention to the release schedule at all (except as it affects regressions affecting a large number of users), since I generally just use "master". I sent the email so that we can agree on where we want to end up eventually, avoiding unnecessary API churn that would later be reverted, and so that it can be fixed eventually.

anyone who volunteers to come up with a first proposal ?

-Matthias 

_______________________________________________
jgit-dev mailing list
jgit-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jgit-dev


Back to the top