| Re: [jgit-dev] Change 59345 in jgit/jgit[master]: bug 342372 - Patch adding end-of-line-conversion using .gita... |
Thanks for the comments. At the end of the day everyone shares the same goal. We want to have the end-of-line issue fixed in a way that people can use it as "commonly" expected. Maybe not all of the 100% of the features but the basic ones. Doing the work in iterations is always a good idea. Which would be the first one you like? The attributes hierarchy collector maybe? Please also give me a statement about any help is (still) needed. I am not eager to submit code when others in your team can do the same thing themselves (maybe even better). I only got active since the end-of-line issue is a major issue that keeps people away from jgit/egit and some also from eclipse at all. Our 200+ developers also need a change in time, so that is the reason why I propably was too fast submitting a complete change. Then smaller iterations could be: 0) accept Arthurs change The I sumbit on top of that 1) a proposal for the AttributesHierarchy on top of that in the TreeIterator, including macro handling and junit tests 2) a proposal for the StreamConversionFactory, not yet cross-wired, just the factory and the junit tests for it 3) a proposal for .gitattributes, .gitignore file change listener in the repo including the life-update in the AttributesHierarchy Until here it is just added supporting functionality, no change in behavior yet. 4) (finally) a proposal for wiring the StreamConversionFactory into the checkout process, this will add the eol-fix to jgit. A realistic plan. Maybe another order makes sense, please advise. Yours Ivan ----- -----Ursprüngliche Nachricht----- Von: Christian Halstrick (Code Review) [mailto:gerrit@xxxxxxxxxxx] Gesendet: Montag, 9. November 2015 23:21 An: Ivan Motsch Cc: Andrey Loskutov; Eclipse Genie; Christian Halstrick Betreff: Change 59345 in jgit/jgit[master]: bug 342372 - Patch adding end-of-line-conversion using .gita... Christian Halstrick has posted comments on this change. Change subject: bug 342372 - Patch adding end-of-line-conversion using .gitattributes, core.eol, core.autocrlf ...................................................................... Patch Set 3: Uff, that change is huge. It is the among the top-10 commits regarding size (added+deleted lines) in JGits history (all that described in a one line commit message :-)). You wrote nice tests so I think there is lot of good functionality in here. But the problem is: in JGit we really have to review and understand(!) the commits from contributors. Just green tests are not sufficient. And understanding 3500 lines in one shot is very hard and very time consuming. Couldn't you try to divide this change in different proposal implementing subfeatures. As an example in one change you could modify the way how to collect attributes. Another change could the rework in the area of Streams handling EOL. Then you introduce an eventing mechanism which watches for changes on .git* files. On the first glance they are independent from each other and could be seperate changes. -- To view, visit https://git.eclipse.org/r/59345 To unsubscribe, visit https://git.eclipse.org/r/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2627921b0d89fd54e8f0a2a4ad541c2d5379751f Gerrit-PatchSet: 3 Gerrit-Project: jgit/jgit Gerrit-Branch: master Gerrit-Owner: Ivan Motsch <ivan.motsch@xxxxxxxxx> Gerrit-Reviewer: Andrey Loskutov <loskutov@xxxxxx> Gerrit-Reviewer: Christian Halstrick <christian.halstrick@xxxxxxx> Gerrit-Reviewer: Eclipse Genie <genie@xxxxxxxxxxx> Gerrit-Reviewer: Hudson CI Gerrit-HasComments: No
Attachment:
smime.p7s
Description: S/MIME cryptographic signature