Re: [jgit-dev] Failing tests because of split packages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]

Re: [jgit-dev] Failing tests because of split packages

From: Matthias Sohn <matthias.sohn@xxxxxxxxxxxxxx>
Date: Sun, 31 Jul 2011 15:28:50 +0200
Delivered-to: jgit-dev@xxxxxxxxxxx
List-archive: <https://dev.eclipse.org/mailman/private/jgit-dev>
List-help: <mailto:jgit-dev-request@eclipse.org?subject=help>
List-subscribe: <https://dev.eclipse.org/mailman/listinfo/jgit-dev>, <mailto:jgit-dev-request@eclipse.org?subject=subscribe>
List-unsubscribe: <https://dev.eclipse.org/mailman/options/jgit-dev>, <mailto:jgit-dev-request@eclipse.org?subject=unsubscribe>

2011/7/30 Ketan Padegaonkar <ketanpadegaonkar@xxxxxxxxx>

Hi,

I've been trying to get two patches[1][2] into jgit, unfortunately the
build is failing because the package 'org.eclipse.jgit.lib' is
available in two plugins 'org.eclipse.jgit' and
'org.eclipse.jgit.test'. So far I've tried to add explicit plugin
dependency(instead of import-package) but nothing seems to work.

Could someone who understands split packages help me resolve this issue?

[1] - http://egit.eclipse.org/r/#change,3940
[2] - http://egit.eclipse.org/r/#change,3480

The jgit build doesn't use tycho but instead uses a maven 2 approach

hence it has no clue what additional.bundles are and also all dependencies

declared in manifest must have corresponding maven dependencies in pom.xml.

I tried adding the missing maven dependency in http://egit.eclipse.org/r/#change,3480

to org.eclipse.jgit.test but this didn't solve the build error.

I think the best way to solve your problem is to move RepositoryTestCase

from org.eclipse.jgit.test to org.eclipse.jgit.junit (in a separate change

which should precede your ant test changes) and remove the package

export for org.eclipse.jgit.lib you added earlier to org.eclipse.jgit.test.

The bundle org.eclipse.jgit.junit is meant for reusable test classes

(e.g. used by egit tests). RepositoryTestCase's base class

LocalDiskRepositoryTestCase is already located there.

Then you can also remove the additional.bundles entry from

org.eclipse.jgit.ant.test 's build.properties (http://egit.eclipse.org/r/#change,3480).

It seems I can't successfully run GitCloneTaskTest from Indigo workbench (it works fine

when run from maven build) :

org.eclipse.jgit.ant.tasks

org.eclipse.jgit.ant.tasks.GitCloneTaskTest

shouldRaiseErrorOnNoUrl(org.eclipse.jgit.ant.tasks.GitCloneTaskTest)

The following error occurred while executing this line:

jar:file:/Applications/Eclipse/indigo/eclipse/plugins/org.apache.ant_1.8.2.v20110505-1300/lib/ant.jar!/org/apache/tools/ant/antlib.xml:37: Problem: failed to create task or type componentdef

Cause: The name is undefined.

Action: Check the spelling.

Action: Check that any custom tasks/types have been declared.

Action: Check that any <presetdef>/<macrodef> declarations have taken place.

at org.apache.tools.ant.ProjectHelper.addLocationToBuildException(ProjectHelper.java:551)

at org.apache.tools.ant.taskdefs.Definer.loadAntlib(Definer.java:445)

at org.apache.tools.ant.taskdefs.Definer.execute(Definer.java:292)

at org.apache.tools.ant.ComponentHelper.checkNamespace(ComponentHelper.java:869)

at org.apache.tools.ant.ComponentHelper.getDefinition(ComponentHelper.java:308)

at org.apache.tools.ant.ComponentHelper.getComponentClass(ComponentHelper.java:298)

at org.apache.tools.ant.ComponentHelper.createNewTask(ComponentHelper.java:547)

at org.apache.tools.ant.ComponentHelper.createTask(ComponentHelper.java:524)

at org.apache.tools.ant.Project.createTask(Project.java:1179)

at org.eclipse.jgit.ant.tasks.GitCloneTaskTest.before(GitCloneTaskTest.java:69)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

at java.lang.reflect.Method.invoke(Method.java:597)

at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)

at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)

at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)

at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:27)

at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)

at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79)

at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71)

at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49)

at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)

at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)

at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)

at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)

at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)

at org.junit.runners.ParentRunner.run(ParentRunner.java:236)

at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)

at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)

at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)

at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)

at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)

at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)

Caused by: jar:file:/Applications/Eclipse/indigo/eclipse/plugins/org.apache.ant_1.8.2.v20110505-1300/lib/ant.jar!/org/apache/tools/ant/antlib.xml:37: Problem: failed to create task or type componentdef

Cause: The name is undefined.

Action: Check the spelling.

Action: Check that any custom tasks/types have been declared.

Action: Check that any <presetdef>/<macrodef> declarations have taken place.

at org.apache.tools.ant.UnknownElement.getNotFoundException(UnknownElement.java:487)

at org.apache.tools.ant.UnknownElement.makeObject(UnknownElement.java:419)

at org.apache.tools.ant.UnknownElement.maybeConfigure(UnknownElement.java:163)

at org.apache.tools.ant.taskdefs.Antlib.execute(Antlib.java:162)

at org.apache.tools.ant.taskdefs.Definer.loadAntlib(Definer.java:443)

... 32 more

shouldRaiseErrorOnEmptyUrl(org.eclipse.jgit.ant.tasks.GitCloneTaskTest)