| Re: [jaxrs-dev] Voting Rules: Always three +1 for each PR? |
Santiago and Christian, You make a valid point here. But see, for typos, I could simply merge them _instantly_ when fixing them on my own with a "1+" rule (implied +1). Even with the "2+" rule I could _instantly_ merge small bug fixes if the fixing author is a committer himself, and I am the assignee (implied +1 by him, implied +1 by me). But with the "3+" rule you wrote up in the Wiki, the assignee must wait for at least a few hours to get the third +1 due to our different time zones or working shifts. This is just an obstacle that I don't like to have, the PMC did not ask for it, and neither did the EF. So I really would be more happy if we could reduce to the "1+" rule as the PMC asked for and as the EF technically enforces, and simply agree that we apply the "3+" rule for "real API changes" only. I do not see that the committers would have a problem with deciding it something changes the API or not. -Markus From: jaxrs-dev-bounces@xxxxxxxxxxx [mailto:jaxrs-dev-bounces@xxxxxxxxxxx] On Behalf Of Santiago Pericas-Geertsen Markus, I understand where you coming from, but this is just too complicated, especially if people cannot agree on the category. It is much easier we have a _single_ rule. If you have a typo or small fix just send an e-mail asking for votes. That shouldn’t take long. Let’s keep things simple. — Santiago On Mar 17, 2018, at 11:55 AM, Markus KARG <markus@xxxxxxxxxxxxxxx> wrote: In the WIKI (https://github.com/eclipse-ee4j/jaxrs-api/wiki/JAX-RS-API-Wiki) Santiago wrote down that for PRs we want to have THREE +1 ever. This is in contrast to what the PMC wants (ONE +1). While I do think that it is a good thing to have TREE +1 for real API changes, I think for bug fixes it is enough to have TWO +1, and for simple types it would be enough to even have a SINGLE +1. I mean, it makes not really sense to wait for three committers to approve a typo. I would like to add these exceptions in the WIKI if nobody objects. So according to the current rules, please vote +1, 0, or -1 now. The vote is open for one seven days from now. ;-) -Markus _______________________________________________ |