Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-tck-dev] How to build the Platform TCK to target JDK8 but support running with JDK11?

Steve, all,

Will GlassFish 6.0.0 target compiling to Java 8 class files?

Is it expected that adding support for running GlassFish 6.0.0 on Java 11, could introduce changes that prevent GlassFish from passing the Jakarta EE 9 Platform TCK on Java 8?

I can imagine that this could easily happen as part of a code change to resolve a TCK test failure on Java 11, that unless someone is volunteering to jump in on addressing such failures on both Java 8 + 11, the fix will only work for Java 11.

Scott

On 6/30/20 6:06 PM, Steve Millidge (Payara) wrote:
One for the glassfish-dev list. That means someone will therefore have to volunteer to do the work to support both. As I said it is non-trivial.

Steve

*From:*jakartaee-tck-dev-bounces@xxxxxxxxxxx <jakartaee-tck-dev-bounces@xxxxxxxxxxx> *On Behalf Of *Gurkan Erdogdu
*Sent:* 30 June 2020 21:42
*To:* jakartaee-tck developer discussions <jakartaee-tck-dev@xxxxxxxxxxx>
*Subject:* Re: [jakartaee-tck-dev] How to build the Platform TCK to target JDK8 but support running with JDK11?

    I believe GlassFish 6.0.0 we will be targeting 11 only.

IMHO, only supporting the JDK 11 for GF6 is not a good idea. Most of the community and developers (more than 90%) still use the JDK 8 as their JDK platform. Only supporting 11 means that we are ignoring them.

Regards.

Gurkan

On Tue, Jun 30, 2020 at 11:24 PM Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx <mailto:steve.millidge@xxxxxxxxxxx>> wrote:

    For GlassFish to support JDK 8 and JDK 11 is non-trivial from my
    experience with Payara, so I believe GlassFish 6.0.0 we will be
    targeting 11 only.

    *From:*jakartaee-tck-dev-bounces@xxxxxxxxxxx
    <mailto:jakartaee-tck-dev-bounces@xxxxxxxxxxx>
    <jakartaee-tck-dev-bounces@xxxxxxxxxxx
    <mailto:jakartaee-tck-dev-bounces@xxxxxxxxxxx>> *On Behalf Of *Kevin
    Sutter
    *Sent:* 30 June 2020 20:39
    *To:* jakartaee-tck developer discussions
    <jakartaee-tck-dev@xxxxxxxxxxx <mailto:jakartaee-tck-dev@xxxxxxxxxxx>>
    *Subject:* Re: [jakartaee-tck-dev] How to build the Platform TCK to
    target JDK8 but support running with JDK11?

    Scott,
    Now we have two threads going on this topic... :-)  That's okay,
    I'll try to keep up...

    Question:  Does Glassfish plan to be compliant with Java 8?  The
last I heard, they were only looking to be compliant with Java 11. If Glassfish is not interested in Java 8, how are we going to determine whether the TCK is executable and testable with Java 8? Since the Java 8 compliance is optional, is this additional testing
    and verification required before we can claim Jakarta EE 9 is
    complete?  Or, do we wait until a vendor tries the Java 8 compliance
    testing and then work through the problems?  This might get messy if
    we have to modify some tests after we go final with Java 11...  I
    don't have all the answers.  Just questions to think about and
    figure out before we claim Jakarta EE 9 is done...

    Thanks for raising this topic!

    ---------------------------------------------------
    Kevin Sutter
    STSM, MicroProfile and Jakarta EE architect @ IBM
    e-mail: sutter@xxxxxxxxxx <mailto:sutter@xxxxxxxxxx>     Twitter:
      @kwsutter
    phone: tl-553-3620 (office), 507-253-3620 (office)
    LinkedIn: https://www.linkedin.com/in/kevinwsutter



    From: Scott Marlow <smarlow@xxxxxxxxxx <mailto:smarlow@xxxxxxxxxx>>
    To: Alwin Joseph <alwin.joseph@xxxxxxxxxx
    <mailto:alwin.joseph@xxxxxxxxxx>>, jakartaee-tck developer
    discussions <jakartaee-tck-dev@xxxxxxxxxxx
    <mailto:jakartaee-tck-dev@xxxxxxxxxxx>>
    Date: 06/30/2020 14:30
    Subject: [EXTERNAL] Re: [jakartaee-tck-dev] How to build the
    Platform TCK to target JDK8 but support running with JDK11?
    Sent by: jakartaee-tck-dev-bounces@xxxxxxxxxxx
    <mailto:jakartaee-tck-dev-bounces@xxxxxxxxxxx>

    ------------------------------------------------------------------------




    Hi Alwin,

    Thanks for raising these points! :-)

    On 6/30/20 1:52 PM, Alwin Joseph wrote:
    > Hi Scott,
> > Can you please help confirm or correct me on the below 2 statements. > > 1. The final TCK bundle should be built with JDK11 only. We will not > build the platform TCK using JDK8.

    We should target generating JDK8 classes, so that compatible
    implementations may also run with JDK8.

     From
    https://eclipse-ee4j.github.io/jakartaee-platform/jakartaee9/JakartaEE9ReleasePlan
    states:
    "
    Java SE Version

    For inclusion in Jakarta EE 9, specification’s APIs MUST be compiled at
    the Java SE 8 source level. However, compatible implementations of the
    Jakarta EE 9 Web Profile and Full Profile MUST certify compatibility on
    Java SE 11. Compatible Implementations MAY additionally certify and
    support Java SE 8.
    "

    Excellent point to raise, the hard requirement is that our build
    generates JDK8 classes, although we could also generate separate JDK8 +
    JDK11 TCK bundles.

    IMO, we could stick with building with JDK8, which is less work than
    switching to building with JDK11.  I will update the $subject to
    reflect
    this point. :)

    > 2. The final TCK bundle should be used to run tests on both JDK8 & JDK11.

    We must run/pass the final TCK bundle on JDK11, as per above linked
    JakartaEE9ReleasePlan.

    Since we expect that EE 9 compatible implementations could also run on
    JDK 8, I think that we should also run against JDK8 ourselves (so that
    we know that its possible).  IMO, we should next focus on passing
    completely with JDK11, so that we finish that first.  Then, we should
    also pass completely with JDK8.

    Thoughts?

    Scott

> > Regards,
    > Alwin
> > On 30/06/20 8:14 pm, Scott Marlow wrote: >> It would be good to get started on building with JDK11, however, we do >> need to target JDK8 so that the EE 9 TCKs also can run on JDK 8 as well.
    >>
>> Has anyone tried building the Platform TCK against JDK 11 yet?  The >> same question for the Standalone TCKs?
    >>
    >>
>> Issue #213 [1] is the general issue for JDK 11 support (Alwin already >> installed JDK 11 via JDK11_HOME=/opt/jdk-11.0.7) + issue#145 [2] is a >> related issue.
    >>
>> I'm trying to build the Platform TCK locally with JDK 11 using [3], I >> have some additional local changes that I will push later and also >> share what I see.
    >>
    >> Scott
    >>
    >> [1] https://github.com/eclipse-ee4j/jakartaee-tck/issues/213
    >> [2] https://github.com/eclipse-ee4j/jakartaee-tck/issues/145
    >> [3] https://github.com/scottmarlow/jakartaee-tck/tree/jdk11
    >>
    >> _______________________________________________
    >> jakartaee-tck-dev mailing list
    >> jakartaee-tck-dev@xxxxxxxxxxx <mailto:jakartaee-tck-dev@xxxxxxxxxxx>
    >> To unsubscribe from this list, visithttps://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev

    _______________________________________________
    jakartaee-tck-dev mailing list
    jakartaee-tck-dev@xxxxxxxxxxx <mailto:jakartaee-tck-dev@xxxxxxxxxxx>
    To unsubscribe from this list, visit
    https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev


    _______________________________________________
    jakartaee-tck-dev mailing list
    jakartaee-tck-dev@xxxxxxxxxxx <mailto:jakartaee-tck-dev@xxxxxxxxxxx>
    To unsubscribe from this list, visit
    https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev



--

Gurkan Erdogdu
http://gurkanerdogdu.blogspot.com


_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev




Back to the top