Re: [jakartaee-spec-project-leads] [jta-dev] Issue with exceptions from

["Steve Millidge (Payara)" <steve.millidge@xxxxxxxxxxx>]

From my  understanding the only reference to those classes within the JDK is from the ORB. However those classes are referenced extensively within Jakarta EE. So if we don’t change them now we will create a further breaking change in the future. That’s why my assumption is that they have to change now and the ORB project is putting in place some code to work out which class to use when.

 

As I said I welcome a broad discussion on the issue.

 

Steve

 

From: jakartaee-spec-project-leads-bounces@xxxxxxxxxxx <jakartaee-spec-project-leads-bounces@xxxxxxxxxxx> On Behalf Of Tom Jenkinson
Sent: 20 August 2020 12:35
To: JakartaEE Spec Project Leadership discussions <jakartaee-spec-project-leads@xxxxxxxxxxx>
Subject: Re: [jakartaee-spec-project-leads] [jta-dev] Issue with exceptions from javax.transaction referenced in JDK

 

Thanks for the input Steve. With Jakarta EE9 and Java SE 8 (a supported configuration) there will be two classes for each of the three exceptions in different packages with no formal relationship.

 

E.g:

https://github.com/openjdk/jdk/blob/jdk8-b120/corba/src/share/classes/javax/transaction/InvalidTransactionException.java

https://github.com/eclipse-ee4j/jta-api/blob/master/api/src/main/java/jakarta/transaction/InvalidTransactionException.java

 

I think this is unusual to the wider Jakarta initiative? Not necessarily wrong but unusual or maybe I missed some other similar examples?

 

 

 

 

 

On Thu, 20 Aug 2020 at 12:28, Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx> wrote:

I believe they should be moved to the Jakarta namespace for Jakarta EE 9.

 

From: jakartaee-spec-project-leads-bounces@xxxxxxxxxxx <jakartaee-spec-project-leads-bounces@xxxxxxxxxxx> On Behalf Of Tom Jenkinson
Sent: 20 August 2020 12:19
To: jta developer discussions <jta-dev@xxxxxxxxxxx>
Cc: JakartaEE Spec Project Leadership discussions <jakartaee-spec-project-leads@xxxxxxxxxxx>
Subject: Re: [jakartaee-spec-project-leads] [jta-dev] Issue with exceptions from javax.transaction referenced in JDK

 

 

 

On Thu, 20 Aug 2020 at 11:41, Lance Andersen <LANCE.ANDERSEN@xxxxxxxxxx> wrote:

Hi Tom,

 

 

 

On Aug 20, 2020, at 5:25 AM, Tom Jenkinson <tom.jenkinson@xxxxxxxxxx> wrote:

 

Hi,

 

I have found that there are some javax.transaction exceptions that are in JDK 8 and at least referred to later. They are also present in Oracle Java SE 8 javadocs. I am not sure what to do.

 

Although they don't appear to be in the Oracle Java SE 14 javadocs:

* https://docs.oracle.com/en/java/javase/14/docs/api/index.html

You can see they are in the Oracle Java SE 8 javadocs:

* https://docs.oracle.com/javase/8/docs/api/javax/transaction/InvalidTransactionException.html

* https://docs.oracle.com/javase/8/docs/api/javax/transaction/TransactionRequiredException.html

* https://docs.oracle.com/javase/8/docs/api/javax/transaction/TransactionRolledbackException.html

 

I removed these from the JDK as part of JEP 320/JDK 11 as they are valid for Java SE 8

 

I can see that the source is present in OpenJDK 8:

* https://github.com/openjdk/jdk/tree/jdk8-b120/corba/src/share/classes/javax/transaction

* The three exceptions are imported and used in https://github.com/openjdk/jdk/blob/jdk8-b120/corba/src/share/classes/com/sun/corba/se/impl/javax/rmi/CORBA/Util.java

 

I don't think the actual source remains on master for OpenJDK (at least in the main repo, maybe CORBA is held elsewhere?):

* https://github.com/openjdk/jdk/tree/master/src

Though I can see there are still references to these classes in OpenJDK (at least):

* https://github.com/openjdk/jdk/search?q=InvalidTransactionException&unscoped_q=InvalidTransactionException

* https://github.com/openjdk/jdk/search?q=TransactionRequiredException&unscoped_q=TransactionRequiredException

* https://github.com/openjdk/jdk/search?

q=TransactionRolledbackException&unscoped_q=TransactionRolledbackException

 

No action is needed though a couple of the fields in the tests I can clean up.  Thank you for pointing this out.

 

Given we support JDK 8 (https://jakarta.ee/resources/JakartaEE-Datasheet-July172020_final.pdf) I am not sure what to do.

 

I am not sure nothing needs done given they are in the javax namespace and there are applications still relying on that.

 

Thanks for the information above Lance

 

I am not sure what to do with Jakarta Transactions as we have currently converted those to jakarta package:

https://github.com/eclipse-ee4j/jta-api/blob/master/api/src/main/java/jakarta/transaction/InvalidTransactionException.java

https://github.com/eclipse-ee4j/jta-api/blob/master/api/src/main/java/jakarta/transaction/TransactionRequiredException.java

https://github.com/eclipse-ee4j/jta-api/blob/master/api/src/main/java/jakarta/transaction/TransactionRolledbackException.java

 

So I can understand better, are you suggesting those exceptions should be moved back (in terms of development as they are already moved on master) to the javax package for Jakarta EE9?

 

 

Best

Lance

 

Thanks in advance for any help and suggestions you can offer,

Tom

_______________________________________________
jta-dev mailing list
jta-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/jta-dev__;!!GqivPVa7Brio!LMgnSdXQYQpBs8aOpHTsnTXCYLaTus_pwra9LOkqb7vrSiAT8g3QAgP9cTXICHxpOA$

 

Best
Lance

------------------

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen@xxxxxxxxxx

 

 

 

_______________________________________________
jta-dev mailing list
jta-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jta-dev

_______________________________________________
jakartaee-spec-project-leads mailing list
jakartaee-spec-project-leads@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads