Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-spec-project-leads] Draft PRs for releases due Friday, July 19th

I agree that we should use Draft PRs.

Also, we previously decided that the review content should be split into two
PRs - one for the javadocs and one for everything else.  For example:

https://github.com/jakartaee/specifications/pull/3
https://github.com/jakartaee/specifications/pull/4

This makes it easier to review the content of the PRs.


Kevin Sutter wrote on 7/16/19 9:57 AM:
> Good to know.  Thanks.
> 
> The other alternative as David pointed out is to use "Draft PRs" via
> _https://help.github.com/en/articles/about-pull-requests#draft-pull-requests_.
>  Since this is a semi-new process not familiar to everyone, the use of labels
> was also allowed.
> 
> BTW, I have already put the [draft] label on your PR!  Thanks for being the
> first real PR (Bill's doesn't count)!  :-)
> 
> 
> ---------------------------------------------------
> Kevin Sutter
> STSM, MicroProfile and Jakarta EE architect
> e-mail:  sutter@xxxxxxxxxx     Twitter:  @kwsutter
> phone: tl-553-3620 (office), 507-253-3620 (office)    
> LinkedIn: https://www.linkedin.com/in/kevinwsutter
> 
> 
> 
> From:        Raymond Auge <raymond.auge@xxxxxxxxxxx>
> To:        JakartaEE Spec Project Leadership discussions
> <jakartaee-spec-project-leads@xxxxxxxxxxx>
> Date:        07/16/2019 11:50 AM
> Subject:        [EXTERNAL] Re: [jakartaee-spec-project-leads] Draft PRs for
> releases due Friday, July 19th
> Sent by:        jakartaee-spec-project-leads-bounces@xxxxxxxxxxx
> --------------------------------------------------------------------------------
> 
> 
> 
> I was not able to add a label myself. I'm guessing only repo owners will be able
> to do this.
> 
> - Ray
> 
> On Tue, Jul 16, 2019 at 12:45 PM Kevin Sutter <_sutter@xxxxxx.com_
> <mailto:sutter@xxxxxxxxxx>> wrote:
> Just a slight update to David's note...
> 
> The Specification PRs referenced by David should be labeled with the [draft]
> label.  When this PR is ready for the ballot/vote, then this [draft] label
> should be replaced with the [final] label.  At this point, these are the only
> two labels available for these Specification PRs.  Additional labels may be
> added in the future as we work through the processes.  Members of the
> Specification Committee can now review and, hopefully, approve the PR via normal
> github workflow processes.
> 
> Thanks!
> 
> ---------------------------------------------------
> Kevin Sutter
> STSM, MicroProfile and Jakarta EE architect
> e-mail:  _sutter@xxxxxx.com_ <mailto:sutter@xxxxxxxxxx>    Twitter:  @kwsutter
> phone: tl-553-3620 (office), 507-253-3620 (office)    
> LinkedIn: _https://www.linkedin.com/in/kevinwsutter_
> 
> 
> 
> From:        David Blevins <_dblevins@tomitribe.com_
> <mailto:dblevins@xxxxxxxxxxxxx>>
> To:        JakartaEE Spec Project Leadership discussions
> <_jakartaee-spec-project-leads@eclipse.org_
> <mailto:jakartaee-spec-project-leads@xxxxxxxxxxx>>
> Date:        07/16/2019 10:56 AM
> Subject:        [EXTERNAL] [jakartaee-spec-project-leads] Draft PRs for releases
> due Friday,        July 19th
> Sent by:        _jakartaee-spec-project-leads-bounces@eclipse.org_
> <mailto:jakartaee-spec-project-leads-bounces@xxxxxxxxxxx>
> --------------------------------------------------------------------------------
> 
> 
> 
> First, everyone's patience is appreciated as we're doing all this for the first
> time and doing a lot of ad-hoc process definition.
> 
> The way we're imagining specification projects would submit their spec to the
> Specification Committee for final review and vote is via PR to the
> _https://github.com/jakartaee/specifications_ repository.  The work is still
> being done, but this repo will be part of the _jakarta.ee_
> <http://jakarta.ee>website and you PR will serve two purposes, one) to get the
> right materials up for review and vote as defined by the JESP 1.2 and TCK
> Process 1.0, but also two) get your specification release details up on
> _https://jakarta.ee_.
> 
> To get started we're asking each specification project to submit a draft PR
> similar to this one, by this Friday July 19th:
> 
> - _https://github.com/jakartaee/specifications/pull/4_
> 
> The PR should either use the "draft" label or (preferably) using Githubs
> official "draft pr" feature:
> 
> - _https://help.github.com/en/articles/about-pull-requests#draft-pull-requests_
> 
> This will allow your specification project to get live feedback from the
> Specification Committee and everyone while you build the materials required for
> the final vote.  Once all looks good and you're ready for final vote, change the
> status of the PR.
> 
> - _https://help.github.com/en/articles/changing-the-stage-of-a-pull-request_
> 
> At this point, the Specification Committee will vote via approvals on the PR. 
> Once approved it will be merged and your final binaries signed and published to
> the download area.
> 
> Speaking as the person who volunteered to create the binary signing/publishing
> Jenkins job, I'm hopeful we can get the PR format consistent enough that it can
> be used as the only URL we need to feed to the Jenkins job and from there it has
> what it needs to do all the final process.  I doubt we'll get there day one, but
> hopefully we can evolve towards that goal.
> 
> 
> ACTION ITEM:
> 
>  - Draft PR like this one: _https://github.com/jakartaee/specifications/pull/4_
>  - Due: Friday, July 19th
>  - Who: All specification projects
> 
> 
> 
> -- 
> David Blevins_
> __http://twitter.com/dblevins__
> __http://www.tomitribe.com_
> 
> 
> 
> 
> 
> 
> -- 
> David Blevins_
> __http://twitter.com/dblevins__
> __http://www.tomitribe.com_
> 310-633-3852
> 
> _______________________________________________
> jakartaee-spec-project-leads mailing list_
> __jakartaee-spec-project-leads@eclipse.org_
> <mailto:jakartaee-spec-project-leads@xxxxxxxxxxx>
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit_
> __https://dev.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads_
> 
> 
> 
> 
> _______________________________________________
> jakartaee-spec-project-leads mailing list_
> __jakartaee-spec-project-leads@eclipse.org_
> <mailto:jakartaee-spec-project-leads@xxxxxxxxxxx>
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit_
> __https://dev.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads_
> 
> 
> -- 
> *_Raymond Augé_* <http://www.liferay.com/web/raymond.auge/profile> (@rotty3000)
> Senior Software Architect *_Liferay, Inc._* <http://www.liferay.com> (@Liferay)
> Board Member & EEG Co-Chair, _OSGi Alliance_
> <http://osgi.org>(@OSGiAlliance)_______________________________________________
> jakartaee-spec-project-leads mailing list
> jakartaee-spec-project-leads@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads
> 
> 
> 
> 
> _______________________________________________
> jakartaee-spec-project-leads mailing list
> jakartaee-spec-project-leads@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads
> 


Back to the top