Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakarta.ee-spec.committee] Possible issue with Servlet spec PR


On Tue, Aug 20, 2019 at 7:36 PM Alasdair Nottingham <alasdair.nottingham@xxxxxxxxx> wrote:
The thread on the TCK list moved on and Scott Marlow seems to be using an EE4J_8 branch which is versioned at 4.0.2, but the PR uses 4.0.3 which does have the annotation.

Indeed, the TCK was executed against 4.0.3, which is in the output of the job log:

+ cd /home/jenkins/workspace/2_servlet-run-tck-against-staged-build/download
+ wget -q https://oss.sonatype.org/content/repositories/staging/jakarta/servlet/jakarta.servlet-api/4.0.3/jakarta.servlet-api-4.0.3.jar -O jakarta.servlet-api.jar

4.0.3 was build from 95f4fbcb0fe1b4d95a6bebbaeda69c811ca5739e

Checking out Revision 95f4fbcb0fe1b4d95a6bebbaeda69c811ca5739e (refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 95f4fbcb0fe1b4d95a6bebbaeda69c811ca5739e
Which was staged in 6ed830e58a2d9e

[INFO] Installing /home/jenkins/workspace/1_servlet-build-and-stage/api/target/jakarta.servlet-api-4.0.3-javadoc.jar.asc to /home/jenkins/workspace/1_servlet-build-and-stage/api/target/nexus-staging/staging/6ed830e58a2d9e/jakarta/servlet/jakarta.servlet-api/4.0.3/jakarta.servlet-api-4.0.3-javadoc.jar.asc
[INFO] Performing remote staging...
[INFO] 
[INFO]  * Remote staging into staging profile ID "6ed830e58a2d9e"
[INFO]  * Created staging repository with ID "jakartaservlet-1011".
The test run for that were:

[javatest.batch] Number of Tests Passed      = 1689
[javatest.batch] Number of Tests Failed      = 0
[javatest.batch] Number of Tests with Errors = 0
[javatest.batch] ********************************************************************************

Not sure why/if/how the signature tests didn't run.

Kind regards,
Arjan




 

So I guess the question is how do we proceed? Does someone need to -1 the vote, or what? Are there other spec teams who have failed to run the signature validation tests against their proposed API release? How would we know?

Alasdair

> On Aug 20, 2019, at 1:32 PM, Scott Stark <sstark@xxxxxxxxxx> wrote:
>
> Correct, it needs to be changed to remove the addition of the annotation. There can’t be an addition that impacts the signatures, and the TCK run has to be using the candidate 4.0.3 staging release.
>
>> On Aug 20, 2019, at 10:19 AM, Alasdair Nottingham <alasdair.nottingham@xxxxxxxxx> wrote:
>>
>> Hi,
>>
>> On the jakartaee-tck-dev mail list Scott Marlow is having issues getting a pass on the servlet API due to the addition of the @Deprecated annotation to the ServletRequest.getRealPath method: https://www.eclipse.org/lists/jakartaee-tck-dev/msg00230.html
>>
>> It was added in this commit: https://github.com/eclipse-ee4j/servlet-api/commit/7ee900a78b2679bf7c9a4c83633eda36acc657f3
>>
>> The Servlet spec PR has this comment:
>>
>> https://github.com/eclipse-ee4j/servlet-api/issues/262#issuecomment-521094783
>>
>> which Arjan said had been done, but I can’t see sign in the output of the signature verification tests being run. Since they are breaking I’m assuming that the signature verification tests either haven’t run, or weren’t run on the Jakarta Servlet API, but on the Java EE Servlet API.
>>
>> Not sure what the right thing to do is, but right now I don’t think servlet should be approved without undoing the addition of @Deprecated.
>>
>> Thoughts?
>> Alasdair
>> _______________________________________________
>> jakarta.ee-spec.committee mailing list
>> jakarta.ee-spec.committee@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>> https://www.eclipse.org/mailman/listinfo/jakarta.ee-spec.committee
>
> _______________________________________________
> jakarta.ee-spec.committee mailing list
> jakarta.ee-spec.committee@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/jakarta.ee-spec.committee

_______________________________________________
jakarta.ee-spec.committee mailing list
jakarta.ee-spec.committee@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jakarta.ee-spec.committee

Back to the top